Skip to content

Add support for Scalar Quantization in HNSW. #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahul-iyer wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −1
Open

Add support for Scalar Quantization in HNSW. #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7add950
Bump extension to quantized rerank cache
rahul-iyer Jul 7, 2026
1d19736
Add transaction callbacks for quantized cache invalidation
rahul-iyer Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension
Open in desktop
Submodule extension updated 15 files
+257 −0 vector/docs/scalar_quantization_hnsw.md
+12 −1 vector/src/catalog/hnsw_index_catalog_entry.cpp
+49 −5 vector/src/function/create_hnsw_index.cpp
+19 −4 vector/src/function/drop_hnsw_index.cpp
+101 −5 vector/src/function/query_hnsw_index.cpp
+24 −0 vector/src/include/index/hnsw_config.h
+124 −3 vector/src/include/index/hnsw_graph.h
+33 −10 vector/src/include/index/hnsw_index.h
+23 −1 vector/src/include/index/hnsw_index_utils.h
+79 −0 vector/src/index/hnsw_config.cpp
+580 −4 vector/src/index/hnsw_graph.cpp
+261 −64 vector/src/index/hnsw_index.cpp
+295 −2 vector/src/index/hnsw_index_utils.cpp
+6 −0 vector/test/test_files/error.test
+66 −0 vector/test/test_files/small.test
6 changes: 6 additions & 0 deletions src/include/transaction/transaction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
#pragma once

#include <atomic>
#include <functional>
#include <mutex>
#include <vector>

#include "common/types/types.h"

Expand Down Expand Up @@ -119,6 +121,8 @@ class LBUG_API Transaction {
void writeCommitToWAL(storage::WAL* wal, uint64_t& walCommitSequence);
void publishCommit();
void rollback(storage::WAL* wal);
void pushCommitCallback(std::function<void(Transaction&)> callback);
void pushRollbackCallback(std::function<void(Transaction&)> callback);

storage::LocalStorage* getLocalStorage() const { return localStorage.get(); }
LocalCacheManager& getLocalCacheManager() { return localCacheManager; }
Expand Down Expand Up @@ -163,6 +167,8 @@ class LBUG_API Transaction {
std::unique_ptr<storage::UndoBuffer> undoBuffer;
std::unique_ptr<storage::LocalWAL> localWAL;
LocalCacheManager localCacheManager;
std::vector<std::function<void(Transaction&)>> commitCallbacks;
std::vector<std::function<void(Transaction&)>> rollbackCallbacks;
bool forceCheckpoint;
std::atomic<bool> hasCatalogChanges;
};
Expand Down
18 changes: 18 additions & 0 deletions src/transaction/transaction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ void Transaction::publishCommit() {
Catalog::Get(*clientContext)->incrementVersion();
hasCatalogChanges = false;
}
for (auto& callback : commitCallbacks) {
callback(*this);
}
commitCallbacks.clear();
rollbackCallbacks.clear();
}

void Transaction::rollback(storage::WAL*) {
Expand All @@ -102,6 +107,19 @@ void Transaction::rollback(storage::WAL*) {
undoBuffer->rollback(clientContext);
localStorage->rollback();
hasCatalogChanges = false;
for (auto& callback : rollbackCallbacks) {
callback(*this);
}
commitCallbacks.clear();
rollbackCallbacks.clear();
}

void Transaction::pushCommitCallback(std::function<void(Transaction&)> callback) {
commitCallbacks.push_back(std::move(callback));
}

void Transaction::pushRollbackCallback(std::function<void(Transaction&)> callback) {
rollbackCallbacks.push_back(std::move(callback));
}

bool Transaction::isUnCommitted(common::table_id_t tableID, common::offset_t nodeOffset) const {
Expand Down
Loading