feat: add Simplified Chinese UI localization#25
feat: add Simplified Chinese UI localization#25fz999999 wants to merge 2 commits intoLampese:mainfrom
Conversation
|
Hi @fz999999 Seems like you completely replaced English texts with Chinese. |
Lampese
left a comment
There was a problem hiding this comment.
Requesting changes for two product-level issues:
-
This PR does not add Simplified Chinese as an additional localization layer; it replaces the only existing UI language with Chinese. The document language, window title, product name, and in-app copy are all switched to hard-coded Chinese without any locale selection, detection, or fallback. That is a regression for current non-Chinese users rather than a new localization capability.
-
The new default
auth.jsonpath flow makes file import more fragile.handleSelectFilenow depends on a backend call to resolve the default path first, and if that command fails, the file dialog is never opened at all. Previously, users could still browse manually even without a default path. The backend also converts the resolved path throughto_str(), which can fail on non-UTF-8 filesystem paths and trigger this regression unnecessarily.
I think both issues should be resolved before merging. The localization part should preserve an English fallback or proper locale switching, and the import picker should still open even if resolving the default path fails.
Summary
~/.codex/auth.jsonVerification
corepack pnpm buildcorepack pnpm tauri buildNotes