Conversation
Lampese
left a comment
There was a problem hiding this comment.
Requesting changes for two regressions introduced alongside the visual refresh:
-
The
pnpm tauriscript change drops the existing wrapper that bootstraps the Rust toolchain environment. The currentscripts/tauri.shscript sources~/.cargo/envwhencargois not already on PATH and gives a clearer failure path for common rustup-based setups. Replacing it with a directtauriinvocation can break existing developer environments that currently work withpnpm tauri .... -
The custom sort dropdown replaces the native
<select>with a button + listbox implementation, but it does not restore the keyboard semantics that the native control provided. There is no arrow-key navigation, no active-descendant/focus management for options, and no typeahead behavior. That makes this a real accessibility regression rather than just a visual restyle.
I think both issues should be resolved before merging. The theme work itself looks coherent, but these two changes broaden the PR from a visual polish pass into behavior regressions for both developers and keyboard users.
Summary
tauriscript to call the local Tauri CLI directly and sync the Cargo lockfile package versionTesting
corepack pnpm buildcorepack pnpm tauri build --no-bundle