Skip to content

Refine dark theme and unify controls#26

Open
SHAREN wants to merge 1 commit intoLampese:mainfrom
SHAREN:codex/graphite-dark-theme
Open

Refine dark theme and unify controls#26
SHAREN wants to merge 1 commit intoLampese:mainfrom
SHAREN:codex/graphite-dark-theme

Conversation

@SHAREN
Copy link
Copy Markdown
Contributor

@SHAREN SHAREN commented Mar 18, 2026

Summary

  • Move the dark theme to a calmer graphite palette with shared surface, text, and semantic tokens
  • Replace the native sort select with a custom dark dropdown so the menu no longer opens with a white system style
  • Unify account cards, progress bars, modals, toasts, and updater controls around consistent primary, secondary, warning, and destructive roles
  • Switch the npm tauri script to call the local Tauri CLI directly and sync the Cargo lockfile package version

Testing

  • corepack pnpm build
  • corepack pnpm tauri build --no-bundle

@Lampese Lampese requested a review from joonshakya March 19, 2026 02:25
Copy link
Copy Markdown
Owner

@Lampese Lampese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for two regressions introduced alongside the visual refresh:

  1. The pnpm tauri script change drops the existing wrapper that bootstraps the Rust toolchain environment. The current scripts/tauri.sh script sources ~/.cargo/env when cargo is not already on PATH and gives a clearer failure path for common rustup-based setups. Replacing it with a direct tauri invocation can break existing developer environments that currently work with pnpm tauri ....

  2. The custom sort dropdown replaces the native <select> with a button + listbox implementation, but it does not restore the keyboard semantics that the native control provided. There is no arrow-key navigation, no active-descendant/focus management for options, and no typeahead behavior. That makes this a real accessibility regression rather than just a visual restyle.

I think both issues should be resolved before merging. The theme work itself looks coherent, but these two changes broaden the PR from a visual polish pass into behavior regressions for both developers and keyboard users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants