Added Maintenance mode option and deployment duration time output#5
Open
aramgevorgyan86 wants to merge 2 commits intomainfrom
Open
Added Maintenance mode option and deployment duration time output#5aramgevorgyan86 wants to merge 2 commits intomainfrom
aramgevorgyan86 wants to merge 2 commits intomainfrom
Conversation
jlandfried
suggested changes
Feb 14, 2023
Contributor
jlandfried
left a comment
jlandfried
left a comment
There was a problem hiding this comment.
Hey @aramgevorgyan86, this is looking really good. Two things:
- If the deployment fails, I would like to see the message that gets posted to slack very loudly indicate that the site is still in maintenance mode, and needs attention. Something like:
@channel
🚨 THE SITE IS STILL IN MAINTENANCE MODE AND NEEDS IMMEDIATE ATTENTION 🚨
- I would like to the message that is sent to slack on a successful deployment to include the start time, end time, and duration of the deployment.
Contributor
Author
|
@jlandfried thank you, let me do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.