test(tests): add Northwind aggregate specification coverage#233
Open
ncipollina wants to merge 2 commits into
Open
test(tests): add Northwind aggregate specification coverage#233ncipollina wants to merge 2 commits into
ncipollina wants to merge 2 commits into
Conversation
Contributor
Author
|
Addressed the required skip-reason fix in
I also investigated So I left that case skipped as Validation after the fix:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds DynamoDB coverage for EF Core's
NorthwindAggregateOperatorsQueryTestBase. The new specification test class mirrors the existing Northwind where/select pattern: supported aggregate/operator cases execute against the shared DynamoDB Northwind fixture with PartiQL baselines, while unsupported query shapes are explicitly skipped with the centralized skip reason.Changes
NorthwindAggregateOperatorsQueryDynamoTestwith overrides for all inherited aggregate-operator specification tests.Fixture.AssertSql(...).SkipReason.QueryShapeNotSupportedso current provider limits are explicit.Validation
dotnet builddotnet test --project tests/EntityFrameworkCore.DynamoDb.SpecificationTests/EntityFrameworkCore.DynamoDb.SpecificationTests.csproj --no-build --filter "FullyQualifiedName~NorthwindAggregateOperatorsQueryDynamoTestDefault" -- --no-progress266 total109 succeeded157 skipped0 failedNotes for Reviewers
This PR is test-only. The skipped cases reflect currently unsupported DynamoDB provider query shapes discovered by first running the full inherited suite unskipped, then classifying failures against existing provider capabilities.