add ltk_troybin: INIBIN v1/v2 (troybin) parser and writer#118
Closed
FrogCsLoL wants to merge 1 commit intoLeagueToolkit:mainfrom
Closed
add ltk_troybin: INIBIN v1/v2 (troybin) parser and writer#118FrogCsLoL wants to merge 1 commit intoLeagueToolkit:mainfrom
FrogCsLoL wants to merge 1 commit intoLeagueToolkit:mainfrom
Conversation
Complete read/write support for League of Legends troybin particle files. - Binary reader for INIBIN v1 (old format) and v2 (typed blocks) - Binary writer for v2 format with all 14 storage types - INI text reader/writer for human-readable editing - Hash dictionary for resolving property names (based on Leischii's TroybinConverter and Rey's TroybinEditor, both MIT licensed) - Lossless binary round-trip via StorageType preservation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FrogCsLoL
force-pushed
the
add-ltk-troybin
branch
from
ee168a9 to
acafcc7
Compare
Contributor
|
Thanks for the PR and the effort put into it. At this stage it doesn’t meet the bar for merging, and addressing the gaps would likely require more review cycles than implementing the crate separately, so I’m going to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full round-trip support for the .troybin particle config format:
Format based on Leischii's TroybinConverter and Rey's TroybinEditor.