add ltk_troybin: INIBIN v1/v2 (troybin) parser and writer#120
Closed
FrogCsLoL wants to merge 1 commit intoLeagueToolkit:mainfrom
Closed
add ltk_troybin: INIBIN v1/v2 (troybin) parser and writer#120FrogCsLoL wants to merge 1 commit intoLeagueToolkit:mainfrom
FrogCsLoL wants to merge 1 commit intoLeagueToolkit:mainfrom
Conversation
Full round-trip support for .troybin particle configuration files: - Read binary v1 and v2 formats - Write binary v2 format - Read/write INI text representation - Hash resolution via built-in property name dictionary Follows ltk crate conventions: - byteorder ReadBytesExt/WriteBytesExt with generic R: Read / W: Write - num_enum TryFromPrimitive/IntoPrimitive on StorageType (#[repr(u8)]) - miette::Diagnostic on error type - Optional serde feature gate on all public types - Private modules with pub use re-exports - HashSet for O(1) hash lookups - Integration tests with real .troybin fixture Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FrogCsLoL
force-pushed
the
add-ltk-troybin
branch
from
c287d61 to
624a998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed every convention gap I could find — matched ltk_meta and ltk_wad patterns exactly. Previous PR got closed with no explanation beyond "doesn't meet the bar." If there are specific issues this time, please point them out instead of just closing it.
Full round-trip support for .troybin particle configuration files:
Follows ltk crate conventions: