Add mypy type checking to CI workflow#59
Merged
Merged
Conversation
dannywillems
force-pushed
the
fix/42-mypy-ci
branch
from
b2e42fd to
9e3fad8
Compare
Fix mypy errors: add types-requests stubs, fix variable type reassignment in query serialization, and add cast for HostResult. Add make typecheck step to both CI jobs. Closes #42
dannywillems
force-pushed
the
fix/42-mypy-ci
branch
from
ea56bc5 to
7f4bfd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make typecheckstep to Linux/macOS CI jobspoetry run mypy leakix/to Windows CI jobTest plan
make typecheckruns successfully locallyCloses #42