Skip to content

Fix clippy pedantic lint errors #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannywillems merged 1 commit into from
Apr 21, 2026
Merged

Fix clippy pedantic lint errors #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,8 +664,7 @@ fn run_local_compose(local_dir: &str, args: &[&str]) -> DeployResult<()> {
/// running.
fn print_dnsmasq_hint() {
let running = cmd::run("brew", &["services", "list"])
.map(|out| out.contains("dnsmasq") && out.contains("started"))
.unwrap_or(false);
.is_ok_and(|out| out.contains("dnsmasq") && out.contains("started"));

if running {
return;
Expand Down
10 changes: 7 additions & 3 deletions tests/compose.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ fn port_mapping_round_trip() {
assert!(v.contains(&"4222:4222".to_string()));
assert!(v.contains(&"8222:8222".to_string()));
}
_ => panic!("expected short ports format"),
docker_compose_types::Ports::Long(_) => panic!("expected short ports format"),
}
}

Expand All @@ -274,7 +274,9 @@ fn caddy_only_depends_on_proxied_apps() {
assert!(!deps.contains_key("nats"));
assert!(!deps.contains_key("agent"));
}
_ => panic!("expected conditional depends_on"),
docker_compose_types::DependsOnOptions::Simple(_) => {
panic!("expected conditional depends_on")
}
}
}

Expand Down Expand Up @@ -303,7 +305,9 @@ fn caddy_depends_on_all_routed_apps_only() {
assert!(deps.contains_key("web"));
assert!(!deps.contains_key("worker"));
}
_ => panic!("expected conditional depends_on"),
docker_compose_types::DependsOnOptions::Simple(_) => {
panic!("expected conditional depends_on")
}
}
}

Expand Down