Open
Conversation
protected __cart_content has no key "items". Hence the remove_item method in LP_Cart never actually worked. Now the remove_item() method of _cart_content takes $cart_id as parameter and removes item if cart_id exists in _cart_content
In cases if customer id is not set then run $this->init() once. It becomes necessary when this function is invoked while doing ajax. While doing ajax $this->_customer_id is always '' which is sorted using ->init()
Author
|
In cases if customer id is not set then run $this->init() once. |
the $src_only argument was not being used to get the profile picture URL only
the $src_only argument was not being used to get the profile picture URL only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protected __cart_content has no key "items". Hence the remove_item method in LP_Cart never actually worked.
Now the remove_item() method of _cart_content takes $cart_id as parameter and removes item if cart_id exists in _cart_content