Skip to content

Fix code comment typo #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
narteysarso wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix code comment typo #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
527c541
fix comment to describe line of code
narteysarso Jun 1, 2022
fdfde4d
fix comment to describe line of code
narteysarso Jun 1, 2022
a4fff4a
fix unused import
narteysarso Jun 1, 2022
4ec623f
fix remove duplicate code
narteysarso Jun 1, 2022
f5a038e
fix remove code duplicate in README.md
narteysarso Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,9 @@ Hardhat is an Ethereum development environment and framework designed for full s
// Burn the sent LP tokens from the user's wallet because they are already sent to
// remove liquidity
_burn(msg.sender, _amount);
// Transfer `ethAmount` of Eth from user's wallet to the contract
// Transfer `ethAmount` of Eth from the contract to the user's wallet
payable(msg.sender).transfer(ethAmount);
// Transfer `cryptoDevTokenAmount` of Crypto Dev tokens from the user's wallet to the contract
// Transfer `cryptoDevTokenAmount` of Crypto Dev tokens from the contract to the user's wallet
ERC20(cryptoDevTokenAddress).transfer(msg.sender, cryptoDevTokenAmount);
return (ethAmount, cryptoDevTokenAmount);
}
Expand Down Expand Up @@ -1229,7 +1229,6 @@ export default function Home() {
setCDBalance(_cdBalance);
setLPBalance(_lpBalance);
setReservedCD(_reservedCD);
setReservedCD(_reservedCD);
setEtherBalanceContract(_ethBalanceContract);
} catch (err) {
console.error(err);
Expand Down
2 changes: 1 addition & 1 deletion hardhat-tutorial/contracts/Exchange.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ contract Exchange is ERC20 {
_burn(msg.sender, _amount);
// Transfer `ethAmount` of Eth from the contract to the user
payable(msg.sender).transfer(ethAmount);
// Transfer `cryptoDevTokenAmount` of `Crypto Dev` tokens from the user's wallet to the contract
// Transfer `cryptoDevTokenAmount` of `Crypto Dev` tokens from the contract to the user's wallet
ERC20(cryptoDevTokenAddress).transfer(msg.sender, cryptoDevTokenAmount);
return (ethAmount, cryptoDevTokenAmount);
}
Expand Down
2 changes: 1 addition & 1 deletion hardhat-tutorial/scripts/deploy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const { ethers } = require("hardhat");
require("dotenv").config({ path: ".env" });

const { CRYPTO_DEV_TOKEN_CONTRACT_ADDRESS } = require("../constants");

async function main() {
Expand Down
1 change: 0 additions & 1 deletion my-app/pages/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ export default function Home() {
setCDBalance(_cdBalance);
setLPBalance(_lpBalance);
setReservedCD(_reservedCD);
setReservedCD(_reservedCD);
setEtherBalanceContract(_ethBalanceContract);
} catch (err) {
console.error(err);
Expand Down