Skip to content

fix: resolve curl and jq 'Argument list too long' errors for large diffs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LearningCircuit merged 2 commits into from
Nov 12, 2025
Merged

fix: resolve curl and jq 'Argument list too long' errors for large diffs #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcf4775
fix: pass prompt via temp file to avoid jq argument limit
LearningCircuit Nov 12, 2025
ee57772
fix: add security and robustness improvements for temp file handling
LearningCircuit Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions ai-reviewer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,12 @@ fi

# Create the JSON request with proper escaping using jq
# Write diff to temporary file to avoid "Argument list too long" error
DIFF_FILE=$(mktemp)
echo "$DIFF_CONTENT" > "$DIFF_FILE"
DIFF_FILE=$(mktemp) || { echo "Failed to create temporary file for diff"; exit 1; }
chmod 600 "$DIFF_FILE"
echo "$DIFF_CONTENT" > "$DIFF_FILE" || { echo "Failed to write diff to temporary file"; rm -f "$DIFF_FILE"; exit 1; }

# Set up trap to ensure temp file cleanup on exit/error
trap 'rm -f "$DIFF_FILE"' EXIT

# Build the user prompt using the diff file
PROMPT_PREFIX="Please analyze this code diff and provide a comprehensive review in markdown format.
Expand Down Expand Up @@ -250,18 +254,22 @@ $PROMPT_PREFIX

$DIFF_CONTENT"


# Clean up diff file
rm -f "$DIFF_FILE"

# Make API call to OpenRouter with simple JSON
# Use generic or repo-specific referer
REFERER_URL="https://github.com/${REPO_FULL_NAME:-unknown/repo}"

# Build JSON payload and pipe to curl to avoid "Argument list too long" error
# Write prompt to temp file to avoid passing large content as command-line argument
PROMPT_FILE=$(mktemp) || { echo "Failed to create temporary file for prompt"; exit 1; }
chmod 600 "$PROMPT_FILE"
echo "$PROMPT" > "$PROMPT_FILE" || { echo "Failed to write prompt to temporary file"; rm -f "$PROMPT_FILE"; exit 1; }

# Update trap to cleanup both temp files
trap 'rm -f "$DIFF_FILE" "$PROMPT_FILE"' EXIT

JSON_PAYLOAD=$(jq -n \
--arg model "$AI_MODEL" \
--arg content "$PROMPT" \
--rawfile content "$PROMPT_FILE" \
--argjson temperature "$AI_TEMPERATURE" \
--argjson max_tokens "$AI_MAX_TOKENS" \
'{
Expand Down