fix: add support for xml property 'seriescode'#57
Open
pants97 wants to merge 1 commit intoLearningProcesss:mainfrom
Open
fix: add support for xml property 'seriescode'#57pants97 wants to merge 1 commit intoLearningProcesss:mainfrom
pants97 wants to merge 1 commit intoLearningProcesss:mainfrom
Conversation
…`<seriescode value="" />` for things of type 'rpgitem'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for xml property 'seriescode', which is returned as
<seriescode value="" />for things of type 'rpgitem';bug: when requesting a thing of type 'rpgitem' the thing's dto parser errors out with an unknown property error:
steps to reproduce:
fix: by adding definitions to support that property the parser does not fail anymore and produces a result as expected;
notes:
174620is that of "Blades in the Dark" rpgitem, found at: https://boardgamegeek.com/rpgitem/174620/blades-in-the-dark146382or43842jestso I couldn't make it run, but it follows the same pattern as other tests so I expect it to run; I ask your indulgence on this, thanks!