Enforce identity from Legion::Identity::Process on all writes and reads#24
Merged
Conversation
Writes: handle_ingest now derives identity_principal_id, identity_id, and identity_canonical_name from Legion::Identity::Process instead of accepting them via kwargs. This prevents privilege escalation through tool calls or AMQP messages that could spoof identity. Reads: handle_query and retrieve_relevant auto-inject requesting_principal_id from Legion::Identity::Process when not explicitly provided, enabling access_scope filtering by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_ingestnow derives identity (principal_id, identity_id, canonical_name) fromLegion::Identity::Processinstead of accepting via kwargs — prevents privilege escalation through tools/AMQPhandle_queryandretrieve_relevantauto-injectrequesting_principal_idfromLegion::Identity::Processwhen not explicitly providedContext
Core fix for the Apollo knowledge leak between users. Identity kwargs were never trusted (tools/actors could spoof them). Now identity is always derived from the authenticated process.
Related: LegionIO/legion-apollo PR #35, LegionIO/lex-knowledge, LegionIO/legion-llm PR #127.
Test plan