Fix three bugs in double right-click fishing mode#29
Open
dlamanna wants to merge 2 commits intoLegolandoBloom:releasefrom
Open
Fix three bugs in double right-click fishing mode#29dlamanna wants to merge 2 commits intoLegolandoBloom:releasefrom
dlamanna wants to merge 2 commits intoLegolandoBloom:releasefrom
Conversation
f7a407c to
e55d669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three bugs in
doubleClick.luathat caused the double right-click fishing method to be unreliable:GetMouseFoci()[1] ~= nil) blocked double-click whenever any UI frame was under the cursor, including non-interactive frames like textures and status bars. Now only blocks on interactive elements (Button,EditBox,CheckButton,Slider).ActionHandlercall — when the second click ended the watch manually, the pendingPoolDelayertimer was still active and would fireAngleur_ActionHandlera third time after expiry. Now the timer is cancelled using a"doubleClickWatch"identifier.MouselookStart/MouselookStopinGLOBAL_MOUSE_DOWN— during the watch state, mouse-down was toggling mouselook, which caused the camera to get stuck or interfere with double-click detection. Removed this block entirely.Test plan