Improve extra item aura refresh timing for fishing buffs#32
Open
thllxb wants to merge 1 commit intoLegolandoBloom:releasefrom
Open
Improve extra item aura refresh timing for fishing buffs#32thllxb wants to merge 1 commit intoLegolandoBloom:releasefrom
thllxb wants to merge 1 commit intoLegolandoBloom:releasefrom
Conversation
Author
|
@LegolandoBloom Can you please review and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates extra item and macro aura refresh behavior so Angleur can reapply before the buff fully expires, using fishing channel timing instead of waiting for aura removal.
Closes #30.
Changes
UnitChannelInfo("player")and use that as the preferred refresh threshold30second threshold when no live fishing channel duration is availableValidation
luaorluajitruntime is available onPATH