Skip to content

ci: add GitHub Actions CI workflow with mocha and eslint#79

Open
czirker wants to merge 1 commit intomasterfrom
feat/ES-2706-add-ci
Open

ci: add GitHub Actions CI workflow with mocha and eslint#79
czirker wants to merge 1 commit intomasterfrom
feat/ES-2706-add-ci

Conversation

@czirker
Copy link
Contributor

@czirker czirker commented Mar 4, 2026

Summary

  • Adds CI workflow that runs on push to master and pull requests
  • mocha tests run as a blocking step (working-directory: src)
  • eslint runs as non-blocking advisory lint step
  • Adds lint script to src/package.json

Task Reference

Changes Made

  • Added .github/workflows/ci.yml
  • Added lint script to src/package.json

Checklist

  • mocha tests (blocking)
  • eslint (non-blocking, continue-on-error: true)
  • Uses actions/checkout@v4 and actions/setup-node@v4

Made with Cursor


Note

Low Risk
Low risk CI-only change; main concern is a duplicate lint script key in src/package.json, which could confuse tooling even though it resolves to the same command.

Overview
Adds a new GitHub Actions workflow (.github/workflows/ci.yml) that runs on pushes and pull requests to master, installs dependencies in src, runs npm run lint as a non-blocking step, and then runs npm test.

Updates src/package.json to include a lint script for ESLint (note: the diff introduces a duplicate lint script entry).

Written by Cursor Bugbot for commit 3a8561d. This will update automatically on new commits. Configure here.

Adds CI that runs on push to master and pull requests:
- mocha (blocking) for unit tests
- eslint (non-blocking, advisory only)
Also adds lint script to package.json.

Task: ES-2706
Made-with: Cursor
@ch-snyk-sa
Copy link

ch-snyk-sa commented Mar 4, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

"test": "mocha 'test/**/*.test.js'"
"test": "mocha 'test/**/*.test.js'",
"lint": "eslint .",
"lint": "eslint ."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate lint key in package.json scripts

Low Severity

The "lint" key appears twice in the scripts object of src/package.json. While JSON parsers typically accept this (using the last value), duplicate keys are technically not allowed by the JSON spec and indicate an accidental copy-paste. This is confusing for anyone reading the file and may cause warnings in strict JSON tooling.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants