ci: add GitHub Actions CI workflow with mocha and eslint#79
Open
ci: add GitHub Actions CI workflow with mocha and eslint#79
Conversation
Adds CI that runs on push to master and pull requests: - mocha (blocking) for unit tests - eslint (non-blocking, advisory only) Also adds lint script to package.json. Task: ES-2706 Made-with: Cursor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| "test": "mocha 'test/**/*.test.js'" | ||
| "test": "mocha 'test/**/*.test.js'", | ||
| "lint": "eslint .", | ||
| "lint": "eslint ." |
There was a problem hiding this comment.
Duplicate lint key in package.json scripts
Low Severity
The "lint" key appears twice in the scripts object of src/package.json. While JSON parsers typically accept this (using the last value), duplicate keys are technically not allowed by the JSON spec and indicate an accidental copy-paste. This is confusing for anyone reading the file and may cause warnings in strict JSON tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Task Reference
Changes Made
Checklist
Made with Cursor
Note
Low Risk
Low risk CI-only change; main concern is a duplicate
lintscript key insrc/package.json, which could confuse tooling even though it resolves to the same command.Overview
Adds a new GitHub Actions workflow (
.github/workflows/ci.yml) that runs on pushes and pull requests tomaster, installs dependencies insrc, runsnpm run lintas a non-blocking step, and then runsnpm test.Updates
src/package.jsonto include alintscript for ESLint (note: the diff introduces a duplicatelintscript entry).Written by Cursor Bugbot for commit 3a8561d. This will update automatically on new commits. Configure here.