-
Notifications
You must be signed in to change notification settings - Fork 312
兼容中文路径跳转 Filza & 改进 alert 弹窗交互 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
中文路径未经过 URL 编码,导致在调用 Filza 打开时无法正确解析并跳转到目标 dylib 文件
为添加一个兼容iOS 14系统的警告框,解决在 iOS 14 系统上选择注入 deb 文件进行注入时没有反应
Owner
|
试了下,就算是原本的实现,中文路径似乎没有问题? |
Owner
|
告警弹窗我更倾向于 iOS 14 上面直接不弹了(但是把导入逻辑补充上去)。反正没多少用户,省得写不同的 .alert。 |
Owner
|
其他的变更另起一个分支 / PR 进行提交吧。不要在一个 PR 里面提交太多内容。 |
Owner
func openInFilza(_ url: URL) {
guard let filzaURL else {
return
}
let fileURL: URL
if #available(iOS 16, *) {
fileURL = filzaURL.appending(path: url.path)
} else {
fileURL = URL(string: filzaURL.absoluteString + (url.path.addingPercentEncoding(withAllowedCharacters: .urlPathAllowed) ?? ""))!
}
UIApplication.shared.open(fileURL)
}
上述两个问题修复已经合入主分支。 |
Owner
|
其他的提交没太看明白。建议按各功能单独提交 PR,包括代码和适当说明(方便 Review),谢谢! |
Contributor
Author
|
其它的不用管搞错了。。。。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增 Filza 对中文路径的兼容,新增 iOS 14 警告弹窗兼容以解决在 iOS 14 系统上选择 deb文件进行注入时没有反应