Update level-ttl to be compatible with abstract-level#139
Open
maxlath wants to merge 8 commits intoLevel:masterfrom
Open
Update level-ttl to be compatible with abstract-level#139maxlath wants to merge 8 commits intoLevel:masterfrom
maxlath wants to merge 8 commits intoLevel:masterfrom
Conversation
and replace nyc with c8, as nyc doesn't support ESM See istanbuljs/nyc#1287 and https://stackoverflow.com/questions/69007082/why-is-my-nyc-code-coverage-not-working-with-esm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started this work without a clear idea of where I was going, mostly to figure-out how to make
level-ttlwork withrave-levelin my use-case, thus the many changes. But maybe that work can be useful for others?Changes summary
lockwithasync-lock. I dropped support for callbacks, which apparently will be the way going forwardmocha: I went that way because that's the tool I know, but if important for consistency with the other modules, I guess it could be converted back to using tape. For tests coverage, I replacednycwithc8as the former doesn't seem to support ESM, but I couldn't find how to producelcov.infowithc8, so that could be a reason to switch back to CJS if that's importantEncodingtype, proofreading welcome.