[BOOKINGSG-9112][Jaz] Checkbox — Migrate styles to Linaria#1094
Open
Jazsley wants to merge 5 commits intopre-release/v4from
Open
[BOOKINGSG-9112][Jaz] Checkbox — Migrate styles to Linaria#1094Jazsley wants to merge 5 commits intopre-release/v4from
Jazsley wants to merge 5 commits intopre-release/v4from
Conversation
Jazsley
changed the title
ghazwan-gt
reviewed
Apr 15, 2026
Contributor
|
for future PRs: do separate the commits for the different css migration steps. this lets the reviewer view individual commits and makes it easier to spot diffs |
qroll
requested changes
Apr 16, 2026
ghazwan-gt
approved these changes
Apr 16, 2026
qroll
requested changes
Apr 16, 2026
| height: 100%; | ||
| cursor: pointer; | ||
|
|
||
| &[disabled] { |
Contributor
There was a problem hiding this comment.
hold up. there's a slight discrepancy here with the logic in master branch
when focusableWhenDisabled is true, the checkbox receives disabled={false} and aria-disabled={true}. meaning this style won't be applied. but we should be expecting 1) no hover style and 2) cursor not-allowed but 3) focus ring preserved
verify with this example
<Checkbox disabled focusableWhenDisabled />
Comment on lines
+12
to
+15
| // ========================================================================= | ||
| // Input behaviour | ||
| // ========================================================================= | ||
| describe("input behaviour", () => { |
Contributor
There was a problem hiding this comment.
can remove this header and this describe block
| await compareScreenshot(story, "variants"); | ||
|
|
||
| await expect(story.layout).toMatchAriaSnapshot(` | ||
| - checkbox "Default" |
Contributor
There was a problem hiding this comment.
update for the small variant too
zhaoyanxzy
reviewed
Apr 17, 2026
| color: ${Colour["icon-primary-subtlest"]}; | ||
| `; | ||
|
|
||
| export const uncheckedDisabledIcon = css` |
There was a problem hiding this comment.
uncheckedDisabledIcon and iconDisabled have the same styling. We should just keep to iconDisabled
…led and removing uncheckedDisabledIcon style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BOOKINGSG-9112][Jaz] Checkbox — Migrate styles to Linaria
Summary
Migrated the
checkboxcomponent fromstyled-componentsto Linariacsstags, replacing V3 design tokens with V4 equivalents and removing all function interpolations in favour ofclsx-based conditional class application.Changes:
V3_Colour/V3_Motiontokens withColour/Motionfrom themestyledtags to Linariacsstags (@linaria/core)SquareIcon,SquareTickFillIcon, etc.) rendered directly withclassNameapplied viaclsx&:not([disabled]):hover + svgChecklist
classNameis chained correctly withclsx