-
Notifications
You must be signed in to change notification settings - Fork 20
[BOOKINGSG-9121][Nghi] migrate toggle and toggle-icon style to linaria #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nghitb
wants to merge
17
commits into
pre-release/v4
Choose a base branch
from
BOOKINGSG-9121
base: pre-release/v4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
112b1d4
[BOOKINGSG-9121][Nghi] rename style files
nghitb a53c721
[BOOKINGSG-9121][Nghi] migrate tokens
nghitb 8023c9d
[BOOKINGSG-9121][Nghi] convert transient props to class based for tog…
nghitb 54cf034
[BOOKINGSG-9121][Nghi] remove style component props for toggle-icon
nghitb 4e70854
[BOOKINGSG-9121][Nghi] convert transient props to class based for toggle
nghitb cf785c2
[BOOKINGSG-9121][Nghi] convert styled components to linaria css for t…
nghitb 51a1486
[BOOKINGSG-9121][Nghi] convert styled components to linaria css for t…
nghitb db88536
[BOOKINGSG-9121][Nghi] Merge branch 'pre-release/v4' into BOOKINGSG-9121
nghitb e625a78
[BOOKINGSG-9121][Nghi] clean up code and modify for more readable code
nghitb 3707f9c
[BOOKINGSG-9121][Nghi] update to cover test
nghitb 70b0272
[BOOKINGSG-9121][Nghi] remove selected style
nghitb 82bafb9
[BOOKINGSG-9121][Nghi] create generic styling to remove duplicate sty…
nghitb c0e6131
[BOOKINGSG-9121][Nghi] add e2e tests
nghitb c8e8ec3
[BOOKINGSG-9121][Nghi] add e2e unit test
nghitb e2d8e58
[BOOKINGSG-9121][Nghi] re-modify import and get classname state function
nghitb c04dc20
[BOOKINGSG-9121][Nghi] Change file e2e tests to type based
nghitb 563aa78
[BOOKINGSG-9121][Nghi] fix Typography import and toggleContainerError…
nghitb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
207 changes: 207 additions & 0 deletions
207
e2e/nextjs-app/src/app/components/toggle/checkbox.e2e.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| "use client"; | ||
| import { Toggle } from "@lifesg/react-design-system/toggle"; | ||
|
|
||
| export default function Story() { | ||
| return ( | ||
| <div className="story-column-container"> | ||
| {/* bordered + indicator */} | ||
| <div className="story-row-container"> | ||
| <Toggle type="checkbox" indicator> | ||
| Bordered + indicator | ||
| </Toggle> | ||
| <Toggle type="checkbox" indicator checked> | ||
| Bordered + indicator checked | ||
| </Toggle> | ||
| <Toggle type="checkbox" indicator disabled> | ||
| Bordered + indicator disabled | ||
| </Toggle> | ||
| <Toggle type="checkbox" indicator checked disabled> | ||
| Bordered + indicator checked disabled | ||
| </Toggle> | ||
| <Toggle type="checkbox" indicator error> | ||
| Bordered + indicator error | ||
| </Toggle> | ||
| <Toggle type="checkbox" indicator error disabled> | ||
| Bordered + indicator error disabled | ||
| </Toggle> | ||
| </div> | ||
|
|
||
| {/* bordered + no indicator */} | ||
| <div className="story-row-container"> | ||
| <Toggle type="checkbox">Bordered</Toggle> | ||
| <Toggle type="checkbox" checked> | ||
| Bordered checked | ||
| </Toggle> | ||
| <Toggle type="checkbox" disabled> | ||
| Bordered disabled | ||
| </Toggle> | ||
| <Toggle type="checkbox" checked disabled> | ||
| Bordered checked disabled | ||
| </Toggle> | ||
| <Toggle type="checkbox" error> | ||
| Bordered error | ||
| </Toggle> | ||
| <Toggle type="checkbox" error disabled> | ||
| Bordered error disabled | ||
| </Toggle> | ||
| </div> | ||
|
|
||
| {/* no-border + indicator */} | ||
| <div className="story-row-container"> | ||
| <Toggle type="checkbox" indicator styleType="no-border"> | ||
| No-border + indicator | ||
| </Toggle> | ||
| <Toggle type="checkbox" indicator styleType="no-border" checked> | ||
| No-border + indicator checked | ||
| </Toggle> | ||
| <Toggle | ||
| type="checkbox" | ||
| indicator | ||
| styleType="no-border" | ||
| disabled | ||
| > | ||
| No-border + indicator disabled | ||
| </Toggle> | ||
| <Toggle | ||
| type="checkbox" | ||
| indicator | ||
| styleType="no-border" | ||
| checked | ||
| disabled | ||
| > | ||
| No-border + indicator checked disabled | ||
| </Toggle> | ||
| <Toggle type="checkbox" indicator styleType="no-border" error> | ||
| No-border + indicator error | ||
| </Toggle> | ||
| <Toggle | ||
| type="checkbox" | ||
| indicator | ||
| styleType="no-border" | ||
| error | ||
| disabled | ||
| > | ||
| No-border + indicator error disabled | ||
| </Toggle> | ||
| </div> | ||
|
|
||
| {/* no-border + no indicator */} | ||
| <div className="story-row-container"> | ||
| <Toggle type="checkbox" styleType="no-border"> | ||
| No-border | ||
| </Toggle> | ||
| <Toggle type="checkbox" styleType="no-border" checked> | ||
| No-border checked | ||
| </Toggle> | ||
| <Toggle type="checkbox" styleType="no-border" disabled> | ||
| No-border disabled | ||
| </Toggle> | ||
| <Toggle type="checkbox" styleType="no-border" checked disabled> | ||
| No-border checked disabled | ||
| </Toggle> | ||
| <Toggle type="checkbox" styleType="no-border" error> | ||
| No-border error | ||
| </Toggle> | ||
| <Toggle type="checkbox" styleType="no-border" error disabled> | ||
| No-border error disabled | ||
| </Toggle> | ||
| </div> | ||
|
|
||
| {/* with sub label */} | ||
| <div className="story-row-container"> | ||
| <Toggle | ||
| type="checkbox" | ||
| indicator | ||
| subLabel="This is a sub label" | ||
| > | ||
| With sub label | ||
| </Toggle> | ||
| <Toggle | ||
| type="checkbox" | ||
| indicator | ||
| checked | ||
| subLabel="This is a sub label" | ||
| > | ||
| With sub label checked | ||
| </Toggle> | ||
| <Toggle | ||
| type="checkbox" | ||
| indicator | ||
| disabled | ||
| subLabel="This is a sub label" | ||
| > | ||
| With sub label disabled | ||
| </Toggle> | ||
| </div> | ||
|
|
||
| {/* with composite section */} | ||
| <div className="story-row-container"> | ||
| <Toggle | ||
| type="checkbox" | ||
| indicator | ||
| compositeSection={{ | ||
| children: <p>Composite section content</p>, | ||
| collapsible: true, | ||
| initialExpanded: false, | ||
| }} | ||
| > | ||
| With composite (collapsed) | ||
| </Toggle> | ||
| <Toggle | ||
| type="checkbox" | ||
| indicator | ||
| checked | ||
| compositeSection={{ | ||
| children: <p>Composite section content</p>, | ||
| collapsible: true, | ||
| initialExpanded: true, | ||
| }} | ||
| > | ||
| With composite (expanded) | ||
| </Toggle> | ||
| </div> | ||
|
|
||
| <div className="story-row-container"> | ||
| <Toggle | ||
| type="checkbox" | ||
| indicator | ||
| error | ||
| compositeSection={{ | ||
| children: <p>Composite section content</p>, | ||
| collapsible: true, | ||
| initialExpanded: false, | ||
| errors: ["Error item 1", "Error item 2"], | ||
| }} | ||
| > | ||
| With composite errors (collapsed) | ||
| </Toggle> | ||
| <Toggle | ||
| type="checkbox" | ||
| indicator | ||
| error | ||
| compositeSection={{ | ||
| children: <p>Composite section content</p>, | ||
| collapsible: true, | ||
| initialExpanded: true, | ||
| errors: ["Error item 1", "Error item 2"], | ||
| }} | ||
| > | ||
| With composite errors (expanded) | ||
| </Toggle> | ||
| </div> | ||
|
|
||
| {/* removable */} | ||
| <div className="story-row-container"> | ||
| <Toggle type="checkbox" indicator removable> | ||
| Removable unchecked | ||
| </Toggle> | ||
| <Toggle type="checkbox" indicator removable checked> | ||
| Removable checked | ||
| </Toggle> | ||
| <Toggle type="checkbox" indicator removable disabled> | ||
| Removable disabled | ||
| </Toggle> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| "use client"; | ||
| import { Toggle } from "@lifesg/react-design-system/toggle"; | ||
|
|
||
| export default function Story() { | ||
| return ( | ||
| <div className="story-column-container"> | ||
| {/* bordered + indicator */} | ||
| <div className="story-row-container"> | ||
| <Toggle type="no" indicator> | ||
| Bordered + indicator | ||
| </Toggle> | ||
| <Toggle type="no" indicator checked> | ||
| Bordered + indicator checked | ||
| </Toggle> | ||
| <Toggle type="no" indicator disabled> | ||
| Bordered + indicator disabled | ||
| </Toggle> | ||
| <Toggle type="no" indicator checked disabled> | ||
| Bordered + indicator checked disabled | ||
| </Toggle> | ||
| <Toggle type="no" indicator error> | ||
| Bordered + indicator error | ||
| </Toggle> | ||
| <Toggle type="no" indicator error disabled> | ||
| Bordered + indicator error disabled | ||
| </Toggle> | ||
| </div> | ||
|
|
||
| {/* bordered + no indicator */} | ||
| <div className="story-row-container"> | ||
| <Toggle type="no">Bordered</Toggle> | ||
| <Toggle type="no" checked> | ||
| Bordered checked | ||
| </Toggle> | ||
| <Toggle type="no" disabled> | ||
| Bordered disabled | ||
| </Toggle> | ||
| <Toggle type="no" checked disabled> | ||
| Bordered checked disabled | ||
| </Toggle> | ||
| <Toggle type="no" error> | ||
| Bordered error | ||
| </Toggle> | ||
| <Toggle type="no" error disabled> | ||
| Bordered error disabled | ||
| </Toggle> | ||
| </div> | ||
|
|
||
| {/* no-border + indicator */} | ||
| <div className="story-row-container"> | ||
| <Toggle type="no" indicator styleType="no-border"> | ||
| No-border + indicator | ||
| </Toggle> | ||
| <Toggle type="no" indicator styleType="no-border" checked> | ||
| No-border + indicator checked | ||
| </Toggle> | ||
| <Toggle type="no" indicator styleType="no-border" disabled> | ||
| No-border + indicator disabled | ||
| </Toggle> | ||
| <Toggle | ||
| type="no" | ||
| indicator | ||
| styleType="no-border" | ||
| checked | ||
| disabled | ||
| > | ||
| No-border + indicator checked disabled | ||
| </Toggle> | ||
| <Toggle type="no" indicator styleType="no-border" error> | ||
| No-border + indicator error | ||
| </Toggle> | ||
| <Toggle | ||
| type="no" | ||
| indicator | ||
| styleType="no-border" | ||
| error | ||
| disabled | ||
| > | ||
| No-border + indicator error disabled | ||
| </Toggle> | ||
| </div> | ||
|
|
||
| {/* no-border + no indicator */} | ||
| <div className="story-row-container"> | ||
| <Toggle type="no" styleType="no-border"> | ||
| No-border | ||
| </Toggle> | ||
| <Toggle type="no" styleType="no-border" checked> | ||
| No-border checked | ||
| </Toggle> | ||
| <Toggle type="no" styleType="no-border" disabled> | ||
| No-border disabled | ||
| </Toggle> | ||
| <Toggle type="no" styleType="no-border" checked disabled> | ||
| No-border checked disabled | ||
| </Toggle> | ||
| <Toggle type="no" styleType="no-border" error> | ||
| No-border error | ||
| </Toggle> | ||
| <Toggle type="no" styleType="no-border" error disabled> | ||
| No-border error disabled | ||
| </Toggle> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit the snapshots after they are generated