[BOOKINGSG-9221][GZ] migrate radio button to linaria#1105
Open
ghazwan-gt wants to merge 14 commits intopre-release/v4from
Open
[BOOKINGSG-9221][GZ] migrate radio button to linaria#1105ghazwan-gt wants to merge 14 commits intopre-release/v4from
ghazwan-gt wants to merge 14 commits intopre-release/v4from
Conversation
ghazwan-gt
requested review from
Jazsley,
nghitb,
qroll,
ryan-nguyen-t,
zhaoyanxzy and
ziggyzet
zhaoyanxzy
reviewed
Apr 17, 2026
| radioUncheckedDisabled: Locator; | ||
| radioCheckedDisabled: Locator; | ||
|
|
||
| radioFocusableDisabled: Locator; |
| ).toMatchAriaSnapshot(` | ||
| - radio [disabled] [checked] | ||
| `); | ||
|
|
There was a problem hiding this comment.
should we add aria snapshot test for radioUncheckedDisabled to make it complete?
qroll
reviewed
Apr 17, 2026
Comment on lines
+62
to
+70
| &.${classes.inputDisabledVisual} { | ||
| cursor: not-allowed; | ||
| } | ||
|
|
||
| &:not(.${classes.inputDisabledVisual}):hover + .${classes.icon} { | ||
| @media (pointer: fine) { | ||
| color: ${Colour["icon-hover"]}; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
hmm we could do this
const inputActive = css`
&:hover + svg {
// ...
}
`
and only apply inputActive when !disabledVisual
qroll
requested changes
Apr 17, 2026
Comment on lines
+29
to
+32
| height: 100%; | ||
| width: 100%; | ||
| color: ${Colour["icon-subtle"]}; | ||
| transition: ${Motion["duration-150"]} ${Motion["ease-default"]}; |
Contributor
There was a problem hiding this comment.
height, width, transition could be a common icon class and uncheckedIcon and checkedIcon can define the colour
| color: ${Colour["icon-subtle"]}; | ||
| transition: ${Motion["duration-150"]} ${Motion["ease-default"]}; | ||
|
|
||
| &.${classes.iconDisabled} { |
Contributor
There was a problem hiding this comment.
this could be a separate css tag
|
|
||
| export default function Story() { | ||
| return ( | ||
| <> |
Contributor
There was a problem hiding this comment.
use the story-column-container here to add more spacing between the size variants
| protected readonly component = "radio-button"; | ||
|
|
||
| public readonly locators: { | ||
| components: { |
Contributor
There was a problem hiding this comment.
ah I intended this to contain the common internal locators for components only. so this nesting of locators is not needed
Comment on lines
+69
to
+91
| await expect( | ||
| story.getContainer( | ||
| story.locators.components.radioUncheckedDefault | ||
| ) | ||
| ).toMatchAriaSnapshot(` | ||
| - radio | ||
| `); | ||
|
|
||
| await expect( | ||
| story.getContainer( | ||
| story.locators.components.radioCheckedDefault | ||
| ) | ||
| ).toMatchAriaSnapshot(` | ||
| - radio [checked] | ||
| `); | ||
|
|
||
| await expect( | ||
| story.getContainer( | ||
| story.locators.components.radioCheckedDisabled | ||
| ) | ||
| ).toMatchAriaSnapshot(` | ||
| - radio [disabled] [checked] | ||
| `); |
Contributor
There was a problem hiding this comment.
can merge into a single snapshot and target story.layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
classNameis chained correctly withclsx