[CCUBE-1989][HN] Add validation schema for otp verificarion field#96
Open
[CCUBE-1989][HN] Add validation schema for otp verificarion field#96
Conversation
weili-govtech
requested changes
Mar 17, 2026
| const requiredRule = validation?.find((rule) => rule.required); | ||
|
|
||
| let contactSchema = Yup.string(); | ||
| if (otpTypeRule?.["otp-type"] === "email") { |
Contributor
There was a problem hiding this comment.
let's apply the validation even without specifying the otp-type validation, I think we can infer from the type
however the otp-type validation is still useful as it allows consumer to customise the error message
Comment on lines
+60
to
+61
| INVALID_EMAIL: "Enter a valid email address.", | ||
| INVALID_PHONE: "Enter a valid contact number.", |
Contributor
There was a problem hiding this comment.
can we use back
ERROR_MESSAGES.EMAIL.INVALIDERROR_MESSAGES.EMAIL.INVALID_SINGAPORE_NUMBER
Contributor
|
update: otp field has been merged in FEE, validation here can be updated accordingly
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add validation schema for otp verificarion field
Changelog entry
Additional information