Skip to content

[CCUBE-2080][XY] Expose customLabels for FileUpload#539

Open
ninjasheeps wants to merge 1 commit intomainfrom
CCUBE-2080
Open

[CCUBE-2080][XY] Expose customLabels for FileUpload#539
ninjasheeps wants to merge 1 commit intomainfrom
CCUBE-2080

Conversation

@ninjasheeps
Copy link
Copy Markdown

Changes

  • Expose customLabels prop for uploadButtonLabel

  • Update dependencies to latest DS version to use customLabels from FileUpload

  • delete branch

@ninjasheeps ninjasheeps requested a review from qroll February 16, 2026 04:38
Comment thread src/components/fields/file-upload/file-upload.tsx Outdated
Comment thread src/components/fields/file-upload/file-upload.tsx Outdated
Copy link
Copy Markdown
Contributor

@qroll qroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests are failing, likely due to some breaking data-testid changes after bumping to the latest design system version. will need to update them accordingly!

Comment thread src/components/fields/file-upload/types.ts Outdated
Comment thread src/stories/3-fields/file-upload/file-upload.stories.tsx Outdated
Comment thread src/components/fields/file-upload/file-upload.tsx Outdated
Comment thread src/__tests__/components/fields/range-select/range-select.spec.tsx Outdated
@ninjasheeps ninjasheeps reopened this Mar 19, 2026
@ninjasheeps
Copy link
Copy Markdown
Author

sorry the branch was too outdated to resolve merge conflicts manually, so i decided to reset everything and implement all the changes on top of the current main

do lmk if this works?

@ninjasheeps ninjasheeps requested a review from qroll March 19, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants