Open
Conversation
qroll
requested changes
Apr 16, 2026
Comment on lines
+137
to
+141
| fireEvent.click(getRadioButtonA()); | ||
| fireEvent.click(getRadioButtonB()); | ||
|
|
||
| expect(getRadioButtonA()).not.toBeChecked(); | ||
| expect(getRadioButtonB()).not.toBeChecked(); |
Contributor
There was a problem hiding this comment.
not required. assume DS covers this implementation detail
Contributor
There was a problem hiding this comment.
please update all the unit tests, thanks!
| name={radioButtonId} | ||
| aria-disabled={disabled ?? option.disabled} | ||
| focusableWhenDisabled={disabled} | ||
| name={id} |
Contributor
There was a problem hiding this comment.
why set name to the fixed id?
Contributor
There was a problem hiding this comment.
check through all other instances
Comment on lines
+100
to
+101
| disabled={disabled ?? option.disabled} | ||
| name={radioButtonId} | ||
| aria-disabled={disabled ?? option.disabled} |
Contributor
There was a problem hiding this comment.
no need to set aria-disabled again, isn't it handled by the component?
Contributor
There was a problem hiding this comment.
check through all other instances
This comment was marked as resolved.
This comment was marked as resolved.
qroll
reviewed
Apr 16, 2026
This reverts commit 446d3a3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Description of changes...
Additional information