Implement Responsive Client-Side Autoscaling#90
Conversation
…osine vectors instead of the data strings. Clean up driver code to make it more readable.
…ored during cosine vector creation. Improve edge case handling in clusters.c.
Add CommentAnchorsExtension.md to document the use of the comment anchors VSCode extension. Add comment anchors support to string_similarity.md. Add a new known issue to string_similarity.md.
…with an unknown type.
…yout, button, editbox, html, image, label, scrollpane, textbutton, & treeview.
Fixes components, dropdowns, and images. Renames flex variables to be more clear. Send parent_w and parent_h to client.
Add tab-height support to apos.c. Add design support to apos.c. Add IsDesign to the WgtrClientInfo struct. Fix spelling mistakes. Clean up.
Add an error message when cxsecVerifySymbol_n() fails. Improve an existing error message when htr_internal_WriteWgtrProperty() fails to write a property of an unknown type. Set Centrallix event listener to be explicitly non-passive, fixing a console error when later code assumes that calling preventDefault() is allowed.
Fix a bug in qprintf() that caused % and & characters inside conditional printing areas to always print, regardless of the condition. Improve documentation for qpfPrintf_va_internal() and qpf_grow_fn_t(). Clean up.
Add shortcut functions: ht_flex_x(), ht_flex_y(), ht_flex_w(), ht_flex_h(). Rename fl_scale_x (was total_fl_x). Rename fl_scale_y (was total_fl_y). Rename fl_scale_w (was total_fl_w). Rename fl_scale_h (was total_fl_h). Rename fl_parent_w (was parent_w). Rename fl_parent_h (was parent_h). Remove ht_flex_format_all and ht_flex_all(). Improve usage of new feature in previously updated widgets. Fix spelling mistakes. Clean up.
Clean up some apps.
Add Math.clamp() and Math.isBetween(). Add getParentSize(), getParentW(), and getParentH(). Refactor getRelativeX/Y/W/H() to call the new getRelative(). Refactor setRelativeX/Y/W/H() to call the new setRelative(). Add fast_setRelativeX/Y(). Add setResponsiveX/Y/W/H() using a new shared setResponsive(). Add responsiveness to moveTo() with the new functions. Fix style guide mistakes. Clean up.
Add support for more edge cases with undefined values to wgtrGetServerProperty(). Add the Log action (and docs). Add the ReloadPage action (and docs). Improve documentation for the Alert widget.
|
@greptileai I think I've addressed your previous comments. Please rereview this PR. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
@greptileai I think I've addressed your previous comments. Please rereview this PR. |
|
This PR is once again ready for human review (after the blockers mentioned above are resolved). |
It will be with us forever in our hearts (and also in the git tree).
Add qpfNoGrow() and qpfSysMallocGrow() grow functions for use when calling qpfPrint_g*() functions. Add qpfPrintf_g() and qpfPrintf_gva() qprintf variants that allow passing a grow function. Improve doc comments for all qpfPrintf*() functions.
Rename mssError() to mssError_internal() which takes a file name and line number. Add mssError() macro that collects and passes the file and line number to mssError_internal(). Remove newline when the error stack is cleared because libraries might have already printed relevant errors.
… the file wasn't compiled.)
Replace htrRenderError() with htrGetErrorHTML() which returns an error HTML string, letting the caller do the rendering. Add htrGetErrorHTML() to ht_render.h so it can be used elsewhere. Update ht_render.c to handle the new syntax for htrGetErrorHTML(). Improve function doc comments.
Fix incorrect boolean logic simplification in htdrv_table.js. Fix missed closing quote.
|
This PR is once again ready for human review (after the blockers mentioned above are resolved). |
|
@greptileai There's a bug somewhere in this PR that causes table row detail widgets to fail to render or render incorrectly. When they do occasionally render, the row that contains them no longer resizes to hold them so they overlap onto the rows below them. Can you figure out what might be causing the bugs with table row detail widgets? (The problem is probably in |
|
@greptileai There's a bug somewhere in this PR that causes table row detail widgets to fail to render or render incorrectly. When they do occasionally render, the row that contains them no longer resizes to hold them so they overlap onto the rows below them. Can you figure out what might be causing the bugs with table row detail widgets? (The problem is probably in htdrv_table.js, but it might be elsewhere in the changes for this PR. Ignore changes merged into the PR from other branches.) |
1 participant
After extracting changes into #87, #88, #89, and removing a few minor/unnecessary changes; this PR is hopefully slightly more manageable.
GitHub Relationships:
This PR is blocked behind the following PRs, which must be merged into master before this PR is reviewed:
--enable-optimizationSeg Fault" #96This PR includes several
TODOs:TODOs for Greg (although other reviewers are welcome to handle these if they have the requisite knowledge), in the following files:ht_render.c,htdrv_page.c,htdrv_tab.c, andhtdrv_table.c.There are several known issues with this code:
widget/pane: resize action (testapps/kardia/modules/payroll/pay_form.app)widget/image: offset & scale actions (not used anywhere)widget/objcanvas: add_osrc_object()ht_get_parent_w/h__INTERNAL()&wgtrGetContainerWidth/Height()should be merged.ht_get_parent_h__INTERNAL()(mine) gives a height 2px taller.Greptile Comment