Skip to content

feat: allow foresters to register at any time by disabling registration phase time check#2321

Open
sergeytimoshin wants to merge 3 commits intomainfrom
sergey/allow-forester-to-register-at-any-time
Open

feat: allow foresters to register at any time by disabling registration phase time check#2321
sergeytimoshin wants to merge 3 commits intomainfrom
sergey/allow-forester-to-register-at-any-time

Conversation

@sergeytimoshin
Copy link
Contributor

@sergeytimoshin sergeytimoshin commented Mar 1, 2026

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Removed epoch registration-time window restriction, enabling registration to occur at any time within the activation window instead of being confined to a specific registration period.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 1, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • sdk-tests/csdk-anchor-full-derived-test/tests/integration_tests.rs is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The is_registration_phase function in the protocol configuration state module is modified to remove the explicit validation check that enforced a registration-time window. The latest_register_epoch_progress check is disabled via commenting, allowing foresters to register during the current epoch at any time within the activation window rather than only during a designated registration period.

Changes

Cohort / File(s) Summary
Registration Phase Logic
programs/registry/src/protocol_config/state.rs
Removed the registration-time window validation check by commenting out the latest_register_epoch_progress guard. Function still computes and returns the registration phase boundary, but no longer enforces the registration period constraint. Change is marked as temporary with an added comment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🌲 The forest gate stands ever open wide,
No gatekeeper guard to turn registrants aside,
Where once strict windows barred the way,
Now foresters may join—any time, any day! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: disabling the registration phase time check to allow foresters to register at any time, which matches the code modification of commenting out the latest_register_epoch_progress check.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 70.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sergey/allow-forester-to-register-at-any-time

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants