feat(auth,http,docs): post-OAuth cleanup — auth getters, idle tests, deadlock fix, docs - #30
Merged
Merged
Conversation
…faults Add explicit link to Git workflow rules in AGENTS.md Read First and Critical Defaults sections. Replace inline Git section in critical-defaults.md with a pointer to the canonical guide. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Add clear_auth_provider(), has_auth_provider(), and auth_provider() to HttpClient for inspecting and resetting the current IAuthProvider without explicitly passing nullptr. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
If cancel_requests() (called from ~HttpClient) was invoked on a group with zero pending/active/failed requests while no processor was running, the callback was queued in m_groups_to_cancel but never processed, causing future.get() to block forever. Mirror the immediate-invoke pattern already used in wait_requests_by_group_id() for empty groups. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Add Test 9 (wait_requests returns immediately on empty group) and Test 10 (wait_requests_for returns true immediately on empty group). Test 10 uncovered a deadlock in cancel_requests_by_group_id when no processor is running and the group is empty — fixed in prior commit. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-OAuth cleanup PR addressing reviewer feedback and a deadlock uncovered by new idle-group tests.
Changes
guides/git-workflow.mdfromAGENTS.mdRead First and Critical Defaults sections.clear_auth_provider(),has_auth_provider(), andauth_provider()getters toHttpClient.cancel_requests()from deadlocking when called on an empty group with no processor running. The callback was queued inm_groups_to_cancelbut never processed; now it mirrorswait_requests_by_group_id()and invokes immediately when the group has zero requests.wait_requests()on empty group returns immediately) and Test 10 (wait_requests_for()on empty group returns true immediately). Test 10 exposed the above deadlock.Verification
ctest --test-dir build-auth-tests— 5/5 passed.http_client_wait_requests_testpassed 5/5 consecutive runs.http_client_auth_provider_testpassed.🤖 Generated with Claude Code