Skip to content

This patch set primarily fixes multiple issues related to compression#761

Merged
Liulongfang merged 11 commits into
Linaro:masterfrom
tomismyfriend:master
Apr 28, 2026
Merged

This patch set primarily fixes multiple issues related to compression#761
Liulongfang merged 11 commits into
Linaro:masterfrom
tomismyfriend:master

Conversation

@tomismyfriend
Copy link
Copy Markdown

Main fixes include:

  • Resolving the compression status issue when the storage buffer is not cleared
  • Moving the tail packet append function to the hisi_comp.c file
  • Removing redundant print information in v1/hisi_zip_udrv
  • Fixing the hashjoin key alignment size issue
  • Cleaning up wd_agg code
  • Addressing some code parameter issues
  • Fixing large number comparison issues
  • Correcting the HPRE parameter comparison method
  • Supporting empty final blocks in stream mode
  • Fixing long timeout issues in synchronous mode when a device failure occurs.

Chenghai Huang and others added 10 commits April 27, 2026 15:22
All LZ77 algorithms need to clear the literal length in the context
to avoid coupling of literal data between data segments in the
stream mode.

Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
When tail data is being compress, if the buffer data is not
cleared, a nospace or again status needs to be returned to notify
the user to add output space.

Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
The tail packet padding function depends on the driver. Therefore,
this function is moved to the driver layer for implementation, so
as to remove unnecessary processes at the algorithm layer.

Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
When the output space is too large, the function is not affected.
Therefore, the printf of displaying a large number of messages
is deleted.

Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
… device failure

1. Add max timeout control and adaptive backoff to prevent long usleep
delays on device failure
2. Implement exponential backoff to reduce context switching overhead
under high load.

Signed-off-by: lizhi <lizhi206@huawei.com>
The key align size of hashjoin is changed now, make it
match the hardware.

Signed-off-by: Wenkai Lin <linwenkai6@hisilicon.com>
Some clean code to improve the readability of the wd_agg code.

Signed-off-by: Wenkai Lin <linwenkai6@hisilicon.com>
Fix parameter validation during the coding process.
Adopt constant-time programming techniques for handling sensitive
data to enhance code resilience against attacks.

Signed-off-by: Longfang Liu <liulongfang@huawei.com>
Add WD_DEFLATE branch in append_store_block() to output a 5-byte store
block when stream compression receives an empty last packet

Signed-off-by: ZongYu Wu <wuzongyu1@huawei.com>
In the HPRE module's big number comparison, the previous
implementation used memcmp to compare big numbers of the same length.
On little-endian platforms, this approach compares data starting from
the Least Significant Bit (LSB), which can lead to incorrect
results—such as a larger value in the lower bits being misinterpreted
as greater overall, even if the higher bits are smaller.
To address this, the comparison logic must be modified to consistently
start from the Most Significant Bit (MSB).

Signed-off-by: Longfang Liu <liulongfang@huawei.com>
The HPRE driver must store and process data in big-endian (MSB)
format as specified by the chip design.
Therefore, the comparison logic for this data should also be described
and implemented following the big-endian convention.

Signed-off-by: Longfang Liu <liulongfang@huawei.com>
@IAMHCHCH
Copy link
Copy Markdown

LGTM

@zhushuai12
Copy link
Copy Markdown

lgtm

1 similar comment
@tomismyfriend
Copy link
Copy Markdown
Author

lgtm

@lizhi-promax
Copy link
Copy Markdown

ok

@lin755
Copy link
Copy Markdown
Collaborator

lin755 commented Apr 28, 2026

lgtm

@Liulongfang Liulongfang changed the title This patch set primarily fixes multiple issues related to compression in the uadk driver and adds some functional enhancements. This patch set primarily fixes multiple issues related to compression Apr 28, 2026
Copy link
Copy Markdown
Collaborator

@Liulongfang Liulongfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Liulongfang Liulongfang merged commit 35760ec into Linaro:master Apr 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants