Skip to content

Fix inverted status checks in the SCSI tape backends #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matejk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix inverted status checks in the SCSI tape backends #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b78e268
fix: drive encryption detection treated MODE SENSE success as failure
matejk Jun 10, 2026
4224ef2
fix: iokit_set_xattr reported success as failure
matejk Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/tape_drivers/linux/sg/sg_tape.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4630,7 +4630,9 @@ static bool is_ame(void *device)
unsigned char buf[TC_MP_READ_WRITE_CTRL_SIZE] = {0};
const int ret = sg_modesense(device, TC_MP_READ_WRITE_CTRL, TC_MP_PC_CURRENT, 0, buf, sizeof(buf));

if (ret != 0) {
/* sg_modesense returns the transferred byte count (> 0) on success and a
* negative error code on failure. */
if (ret < 0) {
char message[100] = {0};
sprintf(message, "failed to get MP %02Xh (%d)", TC_MP_READ_WRITE_CTRL, ret);
ltfsmsg(LTFS_DEBUG, 30392D, __FUNCTION__, message);
Expand Down Expand Up @@ -4720,7 +4722,7 @@ int sg_set_key(void *device, const unsigned char *keyalias, const unsigned char

unsigned char buf[TC_MP_READ_WRITE_CTRL_SIZE] = {0};
ret = sg_modesense(device, TC_MP_READ_WRITE_CTRL, TC_MP_PC_CURRENT, 0, buf, sizeof(buf));
if (ret != DEVICE_GOOD)
if (ret < 0) /* sg_modesense returns a byte count (> 0) on success */
goto out;

ltfs_u16tobe(buffer + 0, sps);
Expand Down Expand Up @@ -4767,8 +4769,9 @@ int sg_set_key(void *device, const unsigned char *keyalias, const unsigned char

memset(buf, 0, sizeof(buf));
ret = sg_modesense(device, TC_MP_READ_WRITE_CTRL, TC_MP_PC_CURRENT, 0, buf, sizeof(buf));
if (ret != DEVICE_GOOD)
if (ret < 0) /* sg_modesense returns a byte count (> 0) on success */
goto out;
ret = DEVICE_GOOD; /* normalize the byte count to a success code */

free:
free(buffer);
Expand Down
16 changes: 6 additions & 10 deletions src/tape_drivers/osx/iokit/iokit_tape.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ static int _get_dump(struct iokit_data *priv, char *fname)
long long data_length, buf_offset;
int dumpfd = -1;
int transfer_size, num_transfers, excess_transfer;
int i, bytes;
int bytes;
unsigned char cap_buf[DUMP_HEADER_SIZE];
unsigned char *dump_buf;
int buf_id;
Expand Down Expand Up @@ -331,14 +331,11 @@ static int _get_dump(struct iokit_data *priv, char *fname)

/* start to transfer data */
buf_offset = 0;
i = 0;
ltfsmsg(LTFS_DEBUG, 30859D);
while(num_transfers)
{
int length;

i++;

/* Allocation Length is transfer_size or excess_transfer*/
if(excess_transfer && num_transfers == 1)
length = excess_transfer;
Expand Down Expand Up @@ -3412,7 +3409,9 @@ int iokit_set_xattr(void *device, const char *name, const char *buf, size_t size
free(null_terminated);

ltfs_profiler_add_entry(priv->profiler, NULL, TAPEBEND_REQ_EXIT(REQ_TC_SETXATTR));
return -LTFS_NO_XATTR;
/* ret is DEVICE_GOOD when one of the vendor attributes matched above;
* returning the hardcoded failure reported success as an error. */
return ret;
}

#define BLOCKLEN_DATA_SIZE 6
Expand Down Expand Up @@ -3629,7 +3628,7 @@ static const char *_generate_product_name(const char *product_id)

int iokit_get_device_list(struct tc_drive_info *buf, int count)
{
int i, ret;
int i;
int found = 0;
int32_t devs = iokit_get_ssc_device_count();
int drive_type;
Expand All @@ -3646,10 +3645,7 @@ int iokit_get_device_list(struct tc_drive_info *buf, int count)
if( devs > 0 ) {
for (i = 0; i < devs; i++) {
if(iokit_find_ssc_device(iokit_device, i) != 0)
{
ret = -EDEV_DEVICE_UNOPENABLE;
continue;
}
drive_type = iokit_get_drive_identifier(iokit_device, &identifier);
if (!drive_type) {
if (found < count && buf) {
Expand All @@ -3665,7 +3661,7 @@ int iokit_get_device_list(struct tc_drive_info *buf, int count)
}
found ++;
}
ret = iokit_free_device(iokit_device);
iokit_free_device(iokit_device);
}
}

Expand Down