Conversation
…s. Making search_studies response consistent
…imple logging breaks previous tests and jupter-execute examples while building documentation. Also good in terms of user perspective to return results]. 2. Updating tests to catch log.warning instead of warnings.warning
khider
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
PangaeaDatasetimplementation by aligning its behavior withNOAADataset, refining logging practices, and updating tests accordingly. It also enhances usability by returning results directly and suppressing noisy third-party logs.Key Changes
1. Return behavior improvements
search_studies()to return a DataFrame instead ofNoneNOAADataset2. Logging refactor
warnings.warnwithlogger.warning3. Test updates
caploginstead ofpytest.warns4. Suppress third-party logging noise
pangaeapy5. Additional improvements
search_studies()behavior consistent across dataset providersdata_type)Motivation
NOAADatasetvsPangaeaDataset)warnings)Impact
Testing
caplogTL;DR
search_studies()now returns resultspangaeapylogs suppressed