Added Dagger 2 architecture to test module#32
Open
gleberemeev wants to merge 35 commits intoLiveTyping:githup-apifrom
Open
Added Dagger 2 architecture to test module#32gleberemeev wants to merge 35 commits intoLiveTyping:githup-apifrom
gleberemeev wants to merge 35 commits intoLiveTyping:githup-apifrom
Conversation
gleberemeev
commented
Sep 2, 2016
gleberemeev
commented
- added test component which provides application scope dependencies and can inject test classes
- added test module which force mock mode
- added test application inherited from project application which eliminates the needs to change app component runtime
- changed test instrumentation runner to use test project application instead of regular app during instrumentation testing
- added some tests
- added some testing utils
- refactored existing tests
added 30 commits
August 31, 2016 19:11
Conflicts: app/build.gradle app/src/internalDebug/java/ru/ltst/u2020mvp/data/api/ServerDatabase.java app/src/main/java/ru/ltst/u2020mvp/data/GalleryDatabase.java app/src/main/java/ru/ltst/u2020mvp/data/api/model/response/Image.java app/src/main/java/ru/ltst/u2020mvp/ui/gallery/GalleryComponent.java app/src/main/java/ru/ltst/u2020mvp/ui/gallery/view/GalleryView.java app/src/main/java/ru/ltst/u2020mvp/ui/image/ImgurImageModule.java build.gradle gradle.properties gradle/wrapper/gradle-wrapper.properties
cosic
reviewed
Sep 23, 2016
| #Wed Aug 31 19:09:15 OMST 2016 | ||
| ======= | ||
| #Sat Sep 10 18:24:49 OMST 2016 | ||
| >>>>>>> upstream/githup-api |
Author
|
@cosic fixed |
Collaborator
|
@gleberemeev а few tests are not passed |
Author
|
@cosic fixed |
Collaborator
|
@gleberemeev Tests still have one crash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.