fix(macos): scale remote scroll input using macOS scroll speed#5133
Merged
Conversation
d05882f to
7f77c0a
Compare
|
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5133 +/- ##
=========================================
Coverage ? 17.87%
=========================================
Files ? 111
Lines ? 24093
Branches ? 10649
=========================================
Hits ? 4307
Misses ? 17322
Partials ? 2464
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This fixes macOS remote scrolling being painfully slow in Sunshine.
Moonlight sends wheel deltas in
WHEEL_DELTA = 120units, including high-resolution sub-detent data. Sunshine’s macOS backend was converting that to CoreGraphics line scroll events on an integer basis with120 -> 1 line, which both ignored high-res scroll granularity and made the macOS Mouse scroll speed setting effectively useless.This changes macOS scoll behavior the following way:
com.apple.scrollwheel.scalingfrom global preferences0.3125to 5 lines per detentDefault scrolling now feels like it's alive, while lower and higher macOS scroll-speed settings still do what you’d expect.
Testing
Was tested with a full build (
scripts/build_macos.sh) and verified manually on Tahoe.Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage