Enable setting custom GitHub Host for GitHub MCP#15
Enable setting custom GitHub Host for GitHub MCP#15dongdong867 wants to merge 2 commits intoLoamStudios:mainfrom
Conversation
|
Taking a look now. |
|
@jeffreyguenther have you finished taking a look? |
|
It's fallen off my radar as I mostly use Feel free to dig in and open PRs that address issues. |
|
I also tell my agents to use Also I think that PR original idea is good, BUT might not work correctly with the (probably most common) use case :
Might have to test it If it works with that use-case, it looks good |
|
The true solution to all these issues is to get the Zed team to provide a way to get the full shell env that Zed uses in the context server. Currently, we don't have a way to do this without putting the ENV values in your Zed config. Not an awesome place to put PATs. That's the root issue. We don't have access to the ENV in the extension. Zed does some fancy stuff to ensure there's a login shell regardless of how its started. It's quite smart. I don't want to be in the business of handing that in this extension. This extension has one primary purpose: provide a button for someone to click to have Zed take over the installation and updating of the MCP executable and forward your settings to it. We can extend the settings passthrough from the Zed settings. I'm good with that as a workaround until either we can upstream a change to the context server extension API or they make the needed change. Hope this helps. |
This pull request adds support for specifying a custom GitHub host URL, which is useful for users working with GitHub Enterprise Server or custom GitHub deployments.
The changes update configuration options, documentation, and environment variable handling to accommodate the new
github_hostsetting.Support for custom GitHub host:
github_hostfield to theGitHubContextServerSettingsstruct insrc/mcp_server_github.rsto allow specifying a custom GitHub URL.GitHubModelContextExtensionimplementation to includeGITHUB_HOSTwhengithub_hostis provided and non-empty.Configuration and documentation updates:
github_hostinconfiguration/default_settings.jsoncto guide users on how to specify a custom GitHub host.configuration/installation_instructions.mdto document the newgithub_hostoption and provide a link to further instructions for GitHub Enterprise Server.