Tab controller #525
Open
Tab controller #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into TabController
… into TabController
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| private void OnTabControllerWindowActivated (object sender, WindowActivatedEventArgs e) | ||
| { | ||
| var newWindow = e.Window; | ||
| var previousWindow = e.PreviousWindow; |
| { | ||
| lock (_logWindowList) | ||
| var logWindow = e.Window; | ||
| var title = e.Title; |
| [SupportedOSPlatform("windows")] | ||
| private void SetTabIcon (LogWindow.LogWindow logWindow, Icon icon) | ||
| { | ||
| if (logWindow == null | logWindow.IsDisposed) |
| _ = BeginInvoke(new SetTabIconDelegate(SetTabIcon), logWindow, icon); | ||
| } | ||
| var data = logWindow.Tag as LogWindowData; | ||
| var icon = GetLedIcon(data.LedState.DiffSum, data); |
| [SupportedOSPlatform("windows")] | ||
| private void SetTabIcon (LogWindow.LogWindow logWindow, Icon icon) | ||
| { | ||
| if (logWindow == null | logWindow.IsDisposed) |
|
|
||
| try | ||
| { | ||
| var handle = icon.Handle; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the tab management logic in the
LogTabWindowclass to use a newTabControllerabstraction, replacing direct manipulation of the_logWindowListanddockPanelcontents. This change centralizes tab/window operations, simplifies event handling, and improves code maintainability. Additionally, extension methods for clipboard text formatting have been moved and modernized.Tab management refactor:
TabControllerto handle all tab/window operations inLogTabWindow, replacing direct use of_logWindowListanddockPanel.Contents. All window addition, removal, activation, and iteration now go throughTabController. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]OnTabControllerWindowAdded,OnTabControllerWindowRemoved,OnTabControllerWindowActivated,OnTabControllerWindowClosing) to respond to tab/window events, improving separation of concerns and encapsulation.Code cleanup and modernization:
_logWindowListand related locking logic throughoutLogTabWindow, simplifying window tracking and concurrency management. [1] [2] [3] [4] [5] [6] [7]SwitchTab,SelectTab,GetListOfOpenFiles,SaveLastOpenFilesList,FindWindowForFile, andRemoveLogWindowto use the newTabControllerAPI. [1] [2] [3] [4] [5] [6]Extension methods update:
ToClipBoardTextextension methods forILogLineandILogLineMemoryfromLogLineExtensions.csto a newExtensions.csfile, using the new C# extension syntax and namespace. [1] [2]Minor code improvements:
These changes make tab/window management more robust and maintainable, and modernize extension method usage.