test: improve coverage on fetch resource plug#3191
Merged
Ziinc merged 2 commits intoLogflare:mainfrom Feb 24, 2026
Merged
Conversation
nelsonmestevao
commented
Feb 23, 2026
| end | ||
|
|
||
| defp uuid?(_), do: false | ||
| defp get_source_from_headers(conn) do |
Contributor
Author
There was a problem hiding this comment.
This was a bug where x-collection would never be called.
Contributor
There was a problem hiding this comment.
Let's remove support for x-collection and collection-related terminology, it is unused and we won't be changing the terminology any time soon.
could you do a separate PR for this? 🙏
Contributor
Author
nelsonmestevao
force-pushed
the
ne/linting
branch
6 times, most recently
from
1629609 to
055be88
Compare
nelsonmestevao
force-pushed
the
ne/linting
branch
from
055be88 to
9e9ea47
Compare
Ziinc
approved these changes
Feb 24, 2026
| end | ||
|
|
||
| defp uuid?(_), do: false | ||
| defp get_source_from_headers(conn) do |
Contributor
There was a problem hiding this comment.
Let's remove support for x-collection and collection-related terminology, it is unused and we won't be changing the terminology any time soon.
could you do a separate PR for this? 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.