refactor: backend execute_query/3 returns Adaptor.QueryResult#3317
Merged
Ziinc merged 2 commits intoLogflare:mainfrom Mar 31, 2026
Merged
refactor: backend execute_query/3 returns Adaptor.QueryResult#3317Ziinc merged 2 commits intoLogflare:mainfrom
Ziinc merged 2 commits intoLogflare:mainfrom
Conversation
msmithstubbs
force-pushed
the
refactor/adaptor-query-result
branch
from
45082bb to
148ccae
Compare
4 tasks
Ziinc
requested changes
Mar 30, 2026
| iex> execute_query(souce_backend, from(s in "log_event_...")) | ||
| {:ok, [%{...}]} | ||
| iex> execute_query(source_backend, from(s in "log_event_...")) | ||
| {:ok, %Logflare.Backends.Adaptor.QueryResult{rows: [%{...}]}} |
Contributor
There was a problem hiding this comment.
Doesn't need to be fully qualified since it is example docstring, not a doctest
| @type t :: t(map()) | ||
| @type t(meta) :: %__MODULE__{ | ||
| rows: [term()], | ||
| meta: meta |
Contributor
There was a problem hiding this comment.
We lost the benefits of having it as a struct if we were to use a generic meta key. Would prefer the keys to be directly on the struct so that we don't need to hunt for the keys in the adaptor modules.
Contributor
Author
There was a problem hiding this comment.
I've flattened all the keys into the struct. Keys that are adaptor specific, such as bq_params and total_bytes_processed, are set to :not_supported by default.
msmithstubbs
force-pushed
the
refactor/adaptor-query-result
branch
2 times, most recently
from
d7225ee to
d6c836b
Compare
msmithstubbs
force-pushed
the
refactor/adaptor-query-result
branch
from
d6c836b to
a7a73ea
Compare
msmithstubbs
force-pushed
the
refactor/adaptor-query-result
branch
from
a7a73ea to
7107b8b
Compare
Ziinc
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Logflare.Backends.Adaptor.QueryResultstruct to provide a consistent response shape for execute_queryPart of #3307