fix: retry log searches in e2e tests to handle slow ingestion in CI#3318
Open
laraujo7 wants to merge 1 commit intoLogflare:mainfrom
Open
fix: retry log searches in e2e tests to handle slow ingestion in CI#3318laraujo7 wants to merge 1 commit intoLogflare:mainfrom
laraujo7 wants to merge 1 commit intoLogflare:mainfrom
Conversation
laraujo7
force-pushed
the
la/e2e-flaky-log-search-retry
branch
from
e2e6d2f to
f88591d
Compare
Ziinc
reviewed
Mar 30, 2026
test/e2e/supabase/lib/utils.ts
Outdated
| import { Page } from '@playwright/test'; | ||
| import { Page } from '@playwright/test'; | ||
|
|
||
| const SEARCH_TIMEOUT = 30_000; |
Contributor
There was a problem hiding this comment.
30s is very long. Can we halve it?
Contributor
Author
There was a problem hiding this comment.
Yeah, possibly. In the worst case, it will run the search for up to 30 seconds.
I’m not entirely sure what’s happening, but my guess is that the logs take a bit of time to appear. So when I perform the search, the log might not be available yet. In this PR, I added a short wait and then retry the search.
I initially set the timeout to 30 seconds, but since it exits early if the log is found, it won’t always take that long. I’ve now reduced it to 10 seconds, which should be sufficient.
laraujo7
force-pushed
the
la/e2e-flaky-log-search-retry
branch
from
f88591d to
618ae2d
Compare
laraujo7
force-pushed
the
la/e2e-flaky-log-search-retry
branch
from
618ae2d to
5b88925
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.