Rework Syslog pool for less "connection errors" noise#3325
Merged
amokan merged 5 commits intoLogflare:mainfrom Apr 1, 2026
Merged
Rework Syslog pool for less "connection errors" noise#3325amokan merged 5 commits intoLogflare:mainfrom
amokan merged 5 commits intoLogflare:mainfrom
Conversation
ruslandoga
commented
Mar 31, 2026
| # close and remove sockets on any error | ||
| def handle_info({tag, socket, reason}, {socket, _backend_config}) | ||
| def handle_info({tag, socket, reason}, {:connected, socket, _config}) | ||
| when tag in [:tcp_error, :ssl_error] do |
Contributor
Author
There was a problem hiding this comment.
There is a race condition here when :idle conn (in pool) becomes {:connected, ...} in the caller during checkout and for some reason errors out and sends the error message to its owner (pool). It gets resolved automatically on the subsequent checkout, but the caller gets a "socket is closed" error.
ruslandoga
changed the title
ruslandoga
changed the title
ruslandoga
force-pushed
the
rd/syslog-no-connect-error
branch
from
dc4e0fc to
1d5eb5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Syslog pool to prevent excessive log noise during connection failures.
Previously, the pool used NimblePool's async worker initialization. Since failing an async init in NimblePool requires raising or exiting, every failed connection attempt resulted in a logged crash -- noisy.
I shifted from
{:async, ...}initialization to an:idleworker state on init. Sockets are now opened on-demand during checkout in the caller, similar to Finch HTTP1 pool.CC @amokan :)