fix sigterm handling for ingestion worker#305
Open
morph027 wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
morph027
force-pushed
the
fix-sigterm-for-ingestion-worker
branch
from
2f6b215 to
2efb597
Compare
Signed-off-by: morph027 <stefan.heitmueller@gmx.com>
morph027
force-pushed
the
fix-sigterm-for-ingestion-worker
branch
from
2efb597 to
e6b6aad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to setup a stack without docker and just plain systemd unit files and the workers always failed to stop gracefully, probably due to something still grips on the BullMQ event loop. This change made it work.
Probably works in docker setup as redis gets terminated too and the subscription event loop handler get's noticed.