Add support for UNIX socket connection to PostgreSQL#352
Open
TobiX wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal prototype. I tried to unify the connection code into one place
(src/helpers/db.ts), since Drizzle seems to need slightly different config in
different places (see the issue linked from #343).
Closes #343
Slightly tested in dev mode, migrations work, application starts.
Caveat: This uses the
hostparameter instead of thepathparameter (seehttps://github.com/porsager/postgres#connection-details), since the connection
code (https://github.com/porsager/postgres/blob/master/src/index.js#L468)
builds the "real" socket name from that. If you want, I can extend the code to
check for the path to make this a little bit more "auto-magic".
Feel free to close if you don't want this feature.