Conversation
…, validation, and memory leak checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes a significant amount of project configuration and test infrastructure, streamlining the repository and its CI/CD process. The changes eliminate Rust and Yarn configuration files, remove all test files, and greatly simplify the GitHub Actions workflow by dropping multi-platform build and test jobs in favor of a single, simpler Node.js-based test job. The overall effect is a major reduction in project complexity, especially around cross-platform support and Rust build/test infrastructure.
CI/CD Workflow Simplification:
.github/workflows/CI.ymlfile is heavily refactored to remove all cross-platform build and test jobs, including matrix builds for various targets and architectures, FreeBSD and WASI builds, and artifact handling. The new workflow only runs linting, formatting, and Node.js-based tests across a matrix of Node.js versions and operating systems. The publish step is also simplified to a singlenpm publishcommand. [1] [2] [3] [4]Removal of Rust and Yarn Configuration:
Cargo.tomland.cargo/config.tomlare deleted, removing all Rust build settings and dependencies. [1] [2].yarnrc.ymlis deleted, removing custom Yarn settings..prettierignoreand.taplo.tomlfiles are removed, eliminating Prettier and Taplo (TOML linter/formatter) ignore and formatting rules. [1] [2]Test Suite Removal:
__test__/cjs/are deleted, including core, concurrency, and lifecycle tests for theGenericObjectPool. [1] [2] [3]Editor and Tooling Settings:
.vscode/settings.jsonis added to auto-approve the use ofnpx tsxin the VSCode terminal, improving developer experience for TypeScript execution.Summary of Most Important Changes:
1. CI/CD and Build Process Overhaul
.github/workflows/CI.yml: removes all multi-platform Rust build and test jobs, artifact handling, and replaces them with a single Node.js-based lint and test workflow. The publish step is also streamlined. [1] [2] [3] [4]2. Removal of Rust and Yarn Configuration
Cargo.toml,.cargo/config.toml, and.yarnrc.yml, removing all Rust and Yarn-specific configuration and dependencies. [1] [2] [3]3. Test Suite Deletion
GenericObjectPool, eliminating automated test coverage for core, concurrency, and lifecycle features. [1] [2] [3]4. Project Formatting and Linting Configuration
.prettierignoreand.taplo.toml, removing Prettier and Taplo ignore and formatting rules. [1] [2]5. Editor Tooling
.vscode/settings.jsonto auto-approvenpx tsxin VSCode terminal for smoother TypeScript workflow.