Fix opencode plugin visible logging by Looted · Pull Request #125 · Looted/kibi

Looted · 2026-03-29T15:52:08Z

No description provided.

… ensure errors are logged to client

Copilot

Pull request overview

This PR updates the kibi-opencode plugin’s logging behavior to be silent in normal operation while keeping errors visible, and adjusts prompt-injection hooks to avoid overwriting existing system prompt entries.

Changes:

Route info/warn logs through structured client.app.log() and keep error-class events visible via console.error.
Change scheduler + bootstrap-needed messaging to emit via the error channel for terminal visibility.
Update prompt injection behavior and tests to preserve existing output.system entries.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
packages/opencode/src/logger.ts	Introduces client-backed structured logging with console-visible errors.
packages/opencode/src/index.ts	Injects logger client; changes prompt injection to append instead of replace; adjusts log levels.
packages/opencode/src/scheduler.ts	Treats sync/check failures as errors (terminal-visible).
packages/opencode/tests/logging-policy.test.ts	Adds coverage ensuring console silence for info/warn and structured log routing.
packages/opencode/tests/index.test.ts	Resets logger client between tests; updates system prompt assertions.
packages/opencode/tests/config.test.ts	Switches config warning assertions to spy on logger.warn.
packages/opencode/tests/hook-contract.test.ts	Adds contract tests for append-only system.transform and chat.params behavior.
packages/opencode/README.md	Documents the logging policy.
packages/opencode/package.json	Bumps package version.
packages/opencode/CHANGELOG.md	Adds 0.5.3 entry describing the logging change.

Copilot · 2026-03-29T15:55:57Z

packages/opencode/src/logger.ts

+  if (client) {
+    client.app.log({
+      body: {
+        service: "kibi-opencode",
+        level: "warn",
+        message: msg,
+      },
+    });


Same as info: this client.app.log(...) Promise is not awaited/handled, which can lead to unhandled promise rejections if the host rejects. Handle the Promise explicitly (e.g., void + .catch(...)).

Copilot · 2026-03-29T15:55:57Z

packages/opencode/src/logger.ts

+  if (client) {
+    client.app.log({
+      body: {
+        service: "kibi-opencode",
+        level: "error",
+        message: msg,
+      },
+    });


The structured client.app.log(...) call is not awaited/handled here either. Since console.error is synchronous but the structured log is async, failures will surface as unhandled rejections unless you explicitly handle the Promise (e.g., void ... .catch(...)).

Copilot · 2026-03-29T15:55:57Z

packages/opencode/src/index.ts

+  // Inject structured logger client so startup/hook messages route to
+  // client.app.log() instead of console when the host provides a client.
+  if (input.client) {
+    logger.setClient(input.client);
+  }


logger keeps client in a module-global variable, but the plugin only calls setClient when input.client is truthy. If the plugin is instantiated multiple times in-process, a previous client's logger can leak into a later invocation (including when input.client is omitted). Consider resetting the logger client at the start of each plugin invocation and then setting it when provided.

Copilot · 2026-03-29T15:55:57Z

packages/opencode/src/index.ts

+        if (injected === currentSystem) {
+          return;
+        }
+        const last =
+          output.system.length > 0
+            ? output.system[output.system.length - 1]
+            : undefined;
+        if (last !== injected) {
+          output.system.push(injected);


In system.transform, you append injectPrompt(currentSystem, ...) to output.system, but injectPrompt returns ${current}\n\n${buildPrompt(...)}. When output.system already has entries, currentSystem is the join of them, so the appended entry contains the entire existing system prompt again, effectively duplicating prior prompts. To truly be append-only, append only the guidance block (e.g., buildPrompt(context)), and/or check for the sentinel across existing entries instead of using injectPrompt with the joined content.

Suggested change

if (injected === currentSystem) {

return;

}

const last =

output.system.length > 0

? output.system[output.system.length - 1]

: undefined;

if (last !== injected) {

output.system.push(injected);

// If injectPrompt made no changes, there's nothing to append.

if (injected === currentSystem) {

return;

}

// injectPrompt is expected to return `${currentSystem}\n\n${guidance}`.

// Derive just the new guidance suffix to avoid duplicating prior content.

let guidance = injected.slice(currentSystem.length);

if (guidance.startsWith("\n\n")) {

guidance = guidance.slice(2);

}

guidance = guidance.trimStart();

if (guidance.length === 0) {

return;

}

const last =

output.system.length > 0

? output.system[output.system.length - 1]

: undefined;

if (last !== guidance) {

output.system.push(guidance);

Copilot · 2026-03-29T15:55:58Z

packages/opencode/package.json

 {
  "name": "kibi-opencode",
-  "version": "0.5.2",
+  "version": "0.5.3",


This PR manually bumps version in package.json. The repo’s release flow uses Changesets to manage versions/changelogs; without a .changeset/*.md file, automated versioning will drift and the release tooling may not pick up this change correctly. Add an appropriate changeset and let changeset version update package.json/changelog.

Suggested change

"version": "0.5.3",

"version": "0.5.2",

Copilot · 2026-03-29T15:55:58Z

packages/opencode/CHANGELOG.md

+## 0.5.3
+
+### Patch Changes
+
+- b543f92: Quieter terminal behavior: normal-operation logs now route through structured `client.app.log()` instead of `console.log`/`console.warn`. Error-class events (bootstrap-needed, sync/check failure, hook/init failure) remain visible in terminal. Preserved error visibility and hook compatibility for prompt injection.
+


Changelog entry appears to be written manually. This repo uses Changesets to generate changelog updates; please add a changeset instead and let the versioning workflow update CHANGELOG.md to keep release automation consistent.

Copilot · 2026-03-29T15:55:58Z

packages/opencode/src/logger.ts

+interface PluginClient {
+  app: {
+    log: (payload: Record<string, unknown>) => Promise<void>;
+  };
+}
+
+let client: PluginClient | null = null;
+
+// implements REQ-opencode-kibi-plugin-v1
+export function setClient(c: PluginClient): void {
+  client = c;
+}


setClient is exported but its parameter type PluginClient is not exported. With declaration: true this will fail TypeScript declaration emit (Exported function has or is using private name 'PluginClient'). Export PluginClient (or inline the type / use a structural type in the function signature) so the package builds.

Copilot · 2026-03-29T15:55:58Z

packages/opencode/src/logger.ts

+  if (client) {
+    client.app.log({
+      body: {
+        service: "kibi-opencode",
+        level: "info",
+        message: msg,
+      },
+    });


client.app.log(...) returns a Promise but the call is neither awaited nor handled. If the host logger rejects, this can create unhandled promise rejections. Consider explicitly fire-and-forget with void ... and attach a .catch(...) (or make the logger methods async and await).

Looted · 2026-03-29T15:57:03Z

@copilot apply changes based on the comments in this thread in a new subpr

Copilot · 2026-03-29T15:57:10Z

@Looted I've opened a new pull request, #126, to work on those changes. Once the pull request is ready, I'll request review from you.

…log promises, reset client per-invocation, fix system.transform dedup, use changeset for versioning Agent-Logs-Url: https://github.com/Looted/kibi/sessions/57278c42-7fda-4283-b6b6-1cf55c043aa9 Co-authored-by: Looted <6255880+Looted@users.noreply.github.com>

fix(opencode): address logger correctness and prompt dedup review feedback

Looted added 11 commits March 29, 2026 12:17

fix(opencode): add structured plugin logger

ba7096b

fix(opencode): silence startup and hook registration output

1e72332

fix(opencode): silence scheduler and summary output

72c4dda

fix(opencode): silence non-error warning paths

e836f9b

fix(opencode): preserve error-only visibility

9f8e7be

fix(opencode): change check failure to logger.error

0506ae4

fix(opencode): preserve hook compatibility for prompt injection

3a9d34e

chore(release): add kibi-opencode logging changeset

b543f92

fix(opencode): add structured error logging

73948d9

fix(opencode): move logger.setClient before workspace health check to…

fbe5636

… ensure errors are logged to client

Version bump

f692581

Copilot AI review requested due to automatic review settings March 29, 2026 15:52

Copilot started reviewing on behalf of Looted March 29, 2026 15:52 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Initial plan

d4f99b4

Copilot AI mentioned this pull request Mar 29, 2026

fix(opencode): address logger correctness and prompt dedup review feedback #126

Merged

Copilot AI and others added 2 commits March 29, 2026 16:02

Merge pull request #126 from Looted/copilot/sub-pr-125

bf9c2b9

fix(opencode): address logger correctness and prompt dedup review feedback

Looted merged commit 7a4d516 into master Mar 29, 2026
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix opencode plugin visible logging#125

Fix opencode plugin visible logging#125
Looted merged 14 commits intomasterfrom
develop

Looted commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Copilot AI Mar 29, 2026

Uh oh!

Looted commented Mar 29, 2026

Uh oh!

Copilot AI commented Mar 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Looted commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Looted commented Mar 29, 2026

Uh oh!

Copilot AI commented Mar 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants