This repository was archived by the owner on Feb 20, 2025. It is now read-only.
Draft
Conversation
which by default makes the file not to be considered as needed for format conversion which is only useful in entrypoints
zrodevkaan
approved these changes
Jul 24, 2024
zrodevkaan
suggested changes
Jul 24, 2024
| } | ||
| parsedBodyWithoutOurImports.unshift(...await addCode(targetedDiscordModApiLibrary.default)); | ||
| if ((targetedDiscordModApiLibrary as { default: IModImplementation } & { convertFormat: (ast_: Statement[]) => Statement[] }).convertFormat == undefined) | ||
| if (shouldConvertFormat == false || (targetedDiscordModApiLibrary as { default: IModImplementation } & { convertFormat: (ast_: Statement[]) => Statement[] }).convertFormat == undefined) |
Contributor
There was a problem hiding this comment.
Actually, could you use !shouldConvertFormat ?
Member
Author
There was a problem hiding this comment.
what if it is a string?
Member
Author
There was a problem hiding this comment.
networking taught me to never trust the user
Contributor
There was a problem hiding this comment.
shouldConvertFormat is a boolean. What "string" are you referencing?
Member
Author
There was a problem hiding this comment.
what if somehow user passes a string to that function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which by default makes the file not to be considered as needed for format conversion which is only useful in entrypoints