feat: Add BracketTransform mode (replace Telex 2)#6
Merged
nhktmdzhg merged 4 commits intoMay 4, 2026
Conversation
- Add EbracketTransform flag (independent of input method) - Transform '[' to 'ơ' and ']' to 'ư' when flag is set - Remove Telex 2 input method definition - Update flag in EstdFlags
- Remove Telex 2 input method completely
- Add BracketTransformFollowFlags, Disabled, NonStart, Everywhere
- Add bracketTransformMode to BambooEngine (like w2uMode)
- Transform [ -> ơ (lower) / Ơ (upper) when enabled
- Transform ] -> ư (lower) / Ư (upper) when enabled
- Remove all [] and {} mappings from input_method_def.go
- Update FcitxBambooEngineOption struct
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable bracket transformation feature to the Bamboo engine, allowing square brackets to be automatically converted to Vietnamese characters (ơ, ư) based on new engine modes and flags. Additionally, it refines and renames several input method definitions, such as merging Telex, VNI, and VIQR layouts. Review feedback identifies a logic error in the SetBracketTransformMode range check that prevents resetting to follow flags, and highlights that changing the VIQR mapping for 'Đ' from 'd' to '\' may break common typing shortcuts like 'dd'.
8137bdd to
23f7312
Compare
1dc4054 to
69b041a
Compare
69b041a to
c10f692
Compare
… IEngine interface
c10f692 to
2764a62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes