Conversation
Add DoubleHyphenToEmDash option following the same pattern as DoubleSpaceToPeriod. When enabled and user types '--', it is replaced with em-dash (—, U+2014).
- Add DoubleHyphenToEmDash to Python settings UI - Support FcitxKey_KP_Subtract (numpad minus) for em-dash - Check no modifiers pressed when triggering replacement
Add option to convert double hyphen to em-dash
--------- Co-authored-by: Nguyen Hoang Ky <nhktmdzhg@gmail.com>
- When at last item and press Down, wrap to first item of current page - When at first item and press Up, wrap to last item of current page - This provides consistent behavior across all pages without jumping between pages
--------- Co-authored-by: Nguyen Hoang Ky <nhktmdzhg@gmail.com>
Signed-off-by: Zebra2711 <zebra2711t@gmail.com>
fix: don’t update preedit in fake BS mode
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates fcitx5-lotus to version 3.1.0, introducing bracket transformation and double hyphen to em-dash conversion. Key changes include a refactored NixOS module with multi-user support and validation, UI label simplifications, and the removal of the deletion monitor thread and its associated synchronization logic. Feedback focuses on the updated navigation logic for candidate lists (Tab, Down, and Up keys), noting that wrapping within the current page is non-standard and suggesting a wrap-around for the entire list to maintain consistency with standard behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.