Update flake.lock and fix build issues with extra-cmake-modules#280
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the nixpkgs revision in flake.lock and modifies the fcitx5-lotus package definition to use kdePackages.extra-cmake-modules instead of extra-cmake-modules. Feedback was provided to avoid the 'with ps;' anti-pattern in the Python package list, suggesting explicit package references to improve clarity and prevent potential naming conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lỗi build không tìm thấy
extra-cmake-modulestrên branch unstable mới nhất của NixOS.Giải pháp: dùng
extra-cmake-modulestừkdePackagesgroup thay choextra-cmake-modulescũ.