Conversation
Update flake.lock and fix build issues with extra-cmake-modules
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the nixpkgs flake lock and modifies the fcitx5-lotus package definition to source extra-cmake-modules from kdePackages. Feedback suggests ensuring consistency by also sourcing Qt base and wrapping hooks from kdePackages, and recommends refactoring the Python package list to use direct attribute access instead of the with keyword for better clarity.
| nativeBuildInputs = [ | ||
| cmake | ||
| extra-cmake-modules | ||
| kdePackages.extra-cmake-modules |
There was a problem hiding this comment.
When using kdePackages.extra-cmake-modules, it is recommended to also use kdePackages.qtbase and kdePackages.wrapQtAppsHook (instead of the top-level qt6 attributes) to ensure that all Qt/KDE components are sourced from the same consistent package set. This prevents potential issues with mismatched Qt versions in the build environment.
| (python3.withPackages ( | ||
| ps: with ps; [ | ||
| pyqt6 | ||
| dbus-python | ||
| qtpy | ||
| ])) | ||
| ] | ||
| )) |
There was a problem hiding this comment.
The reformatted Python package list is unnecessarily verbose and continues to use the with keyword, which is generally discouraged in Nixpkgs as it can lead to scoping issues and makes it less clear where each package originates. A more idiomatic and concise approach is to access the packages directly from the ps argument.
(python3.withPackages (ps: [
ps.pyqt6
ps.dbus-python
ps.qtpy
]))
2 participants
No description provided.