Skip to content

Dev#284

Merged
nhktmdzhg merged 2 commits into
mainfrom
dev
May 15, 2026
Merged

Dev#284
nhktmdzhg merged 2 commits into
mainfrom
dev

Conversation

@nhktmdzhg
Copy link
Copy Markdown
Collaborator

No description provided.

@github-project-automation github-project-automation Bot moved this to Backlog in Kanban May 15, 2026
@nhktmdzhg nhktmdzhg merged commit b51903a into main May 15, 2026
36 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Kanban May 15, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the fcitx5-lotus Nix derivation to allow extra-cmake-modules to be provided either as a direct argument or via kdePackages. The reviewer suggested improving the robustness of the attribute check using the ? operator and providing a more descriptive error message in the throw statement to aid in troubleshooting.

Comment on lines +21 to +27
ecm =
if extra-cmake-modules != null then
extra-cmake-modules
else if kdePackages != null then
kdePackages.extra-cmake-modules
else
throw "Cannot find extra-cmake-modules";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The error message in the throw statement could be more descriptive to help identify which package is failing and why. Additionally, using the ? operator to check for the existence of extra-cmake-modules within kdePackages is more robust than just checking if kdePackages is not null, as it handles cases where kdePackages might be an empty set.

  ecm =
    if extra-cmake-modules != null then
      extra-cmake-modules
    else if kdePackages ? extra-cmake-modules then
      kdePackages.extra-cmake-modules
    else
      throw "fcitx5-lotus: extra-cmake-modules not found; please provide it directly or via kdePackages.";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants