View and edit task connect api#220
Merged
ivonanicetin merged 10 commits intomainfrom Mar 28, 2025
Merged
Conversation
LucasSlunt
requested changes
Mar 28, 2025
Owner
LucasSlunt
left a comment
LucasSlunt
left a comment
There was a problem hiding this comment.
testPrePersistCreatedAtField() in NotificationEntityTest class fails. It was fixed in PR #200, so check there for potential fixes. testMassAssignToTask() also fails, though you can comment it out and we'll fix it later.
Good work with the naming bug fix and task connect api, and the styling is appreciated. Just make sure that testPrePersistCreatedAtField() passes and this will be good to merge.
…ject into ViewAndEditTaskConnectAPI
ivonanicetin
approved these changes
Mar 28, 2025
Collaborator
ivonanicetin
left a comment
ivonanicetin
left a comment
There was a problem hiding this comment.
tests all passed, code looks good, functions work as expected
ivonanicetin
approved these changes
Mar 28, 2025
Collaborator
ivonanicetin
left a comment
ivonanicetin
left a comment
There was a problem hiding this comment.
test fixed , everything looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now update view edit all the tasks also fixes create task
Resolves #219